From owner-svn-src-head@FreeBSD.ORG Wed May 23 07:01:36 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ECCF51065673; Wed, 23 May 2012 07:01:36 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 98A4E8FC0C; Wed, 23 May 2012 07:01:36 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so10219700pbb.13 for ; Wed, 23 May 2012 00:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:in-reply-to:mime-version:content-transfer-encoding :content-type:message-id:cc:x-mailer:from:subject:date:to; bh=z57VCxhiYQtj+iHUqRva0J2wXgOSNtJYPSTKU+XqeBY=; b=aRfGmKC+3cPrV65lRJkCaiZC5ZpBdzWLETrOwiQZPIn0X0zBLRzuEEMuZ71haqLeKw 0VLKbShNsf28lcjq7wupvpxXva8zDav4kQkZ8cAFuoYBg4lip0uzdSCIOY+gM90xO2Y0 eVzOPzOHFs6totqZST7JKZbMEYaH7ak6emJb8ejswzTHgmYs4RM4Bfzu2ifJ87WvwCDt d6KvhrkXQur8yboYhd34gZXGULlNDEhDoZVFJfelOQSuLXQlqRGdPwwAWkMdFHrLTTWl b2YeBhSfs3UPl/Wx9KtgcLaU5RcZx/XI2+PS+nSeXAmyXp44TffshZjMmX3mLFODqnGm 7PKw== Received: by 10.68.197.166 with SMTP id iv6mr7658240pbc.40.1337756496391; Wed, 23 May 2012 00:01:36 -0700 (PDT) Received: from [10.65.51.135] (mobile-166-147-092-070.mycingular.net. [166.147.92.70]) by mx.google.com with ESMTPS id px4sm873141pbb.53.2012.05.23.00.01.34 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 May 2012 00:01:35 -0700 (PDT) References: <201205221818.q4MII7lk019626@svn.freebsd.org> <20120523050739.H3621@besplex.bde.org> <4FBC86B3.8020105@FreeBSD.org> In-Reply-To: <4FBC86B3.8020105@FreeBSD.org> Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: X-Mailer: iPhone Mail (9B206) From: Garrett Cooper Date: Wed, 23 May 2012 00:01:29 -0700 To: Dimitry Andric Cc: "mdf@FreeBSD.org" , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "David E. O'Brien" , BruceEvans , "svn-src-head@freebsd.org" Subject: Re: svn commit: r235797 - head/contrib/gcc X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2012 07:01:37 -0000 On May 22, 2012, at 11:41 PM, Dimitry Andric wrote: > On 2012-05-22 23:07, mdf@FreeBSD.org wrote: > ... >> We run with the following at Isilon, which is somewhat bogus because >> it allows a bit of sloppiness in types, but is also terribly >> convenient since it means no casting on printf arguments is needed: >=20 > Please don't. If you want to write portable code, use the (admittedly > horrible) PRId64 macros instead. Agreed, because the patch attached earlier disguises issues with signedness (= for one) and I've seen some interesting bugs creep in because of issues like= that, an it's painful cleaning up those problems later on (esp. considering= that clang will replace gcc not too far down the line)... Thanks, -Garrett=