From owner-freebsd-current@FreeBSD.ORG Tue Sep 9 13:17:25 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F8CA16A4C0; Tue, 9 Sep 2003 13:17:25 -0700 (PDT) Received: from dan.emsphone.com (dan.emsphone.com [199.67.51.101]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE0A043FAF; Tue, 9 Sep 2003 13:17:21 -0700 (PDT) (envelope-from dan@dan.emsphone.com) Received: (from dan@localhost) by dan.emsphone.com (8.12.9/8.12.9) id h89KHF3F019485; Tue, 9 Sep 2003 15:17:15 -0500 (CDT) (envelope-from dan) Date: Tue, 9 Sep 2003 15:17:15 -0500 From: Dan Nelson To: Kevin Oberman Message-ID: <20030909201715.GW48339@dan.emsphone.com> References: <20030909010434.H26496@znfgre.qbhto.arg> <20030909190901.9FF8C5D04@ptavv.es.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030909190901.9FF8C5D04@ptavv.es.net> X-OS: FreeBSD 5.1-CURRENT X-message-flag: Outlook Error User-Agent: Mutt/1.5.4i cc: Harald Schmalzbauer cc: Doug Barton cc: freebsd-current@freebsd.org Subject: Re: -pthread deprecated, but when? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2003 20:17:25 -0000 In the last episode (Sep 09), Kevin Oberman said: > > From: Doug Barton The right thing to do is to > > file a PR when this stuff breaks. This process will actually be a > > good thing, since ports should not have been compiling on -current > > with -pthread for a long time now. > > > > BTW, several ports have already been fixed, and the fix is not > > difficult. I do the following in my ports: > > > > @ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched > > @ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \ > > -e 's#malloc.h#stdlib.h#g' \ > > ${WRKSRC}/configure.Patched > ${WRKSRC}/configure > > > > Any occurences of -lc_r should be changed to ${PTHREAD_LIBS} too. > > For which versions of FreeBSD? I just tried using ${PTHREAD_LIBS}, > but the loader could not find any of the pthread routines. I assume > it should be defined in one of the .mk files, but it does not seem to > be on either a current (yesterday) or an older current (9/19). bsd.port.mk has used -lc_r for pthreads on 5.0 since March 2001 (rev 1.363). http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r1=1.362&r2=1.363&f=h -- Dan Nelson dnelson@allantgroup.com