From nobody Tue Feb 24 22:09:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fLBhP3sjHz6T4tP for ; Tue, 24 Feb 2026 22:09:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fLBhP0vyNz45Zk for ; Tue, 24 Feb 2026 22:09:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771970949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qjSg0nUWnqHniJasF1oE2UqdJHsRJjdAFYnZMKLtJw0=; b=nKsbZ2qAQeRBcyTGeMg7vMh+uxAqXOkm8/zIqSKYbsnNV2V1UE8wKiRmtqNGG9+uWNI0cZ Wa07T6zP8yxOEimIBkxapIQIOZwR/6Jd7QvIVNnA9MjoR8db38xWWWaMJbzoHf2WtpasZP TlDKlp5dE94CpyYWwILx3z1XlCiul2WtRdc2ZlKBi0vyr5PtLV3xJ8WD7QNr5mkxO8sQ6u Cso7Mc8f3bD90LAyTvfd7ppBEmDs9ocku24ezcC/Q9ZJ5m/pPgGtRgi2qU7sBiY7EhS6Go DSKNpAIpOFkt5zKUpP8PIMI3bTyeokbjVGlESnXVYjgBWnOnR6ekBVE1HYRSaQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771970949; a=rsa-sha256; cv=none; b=pfdd9llpz3X9Y8WeP5uttpEmIEnjiSzupAj0I4d09Nvdzc7oIdD277RRP51I92AvRLGwO+ r2Iww6qD9PfgGdAfL24Hh8FpofcUTGwhLTi7x2t3/lQx6y7AIPvVlnKgbHNJNfsNqP0SOr 43bSKSULGcfzxdW1arloAUN/KanjM4DHdnnjlYzmpS/LhXWAj3xolobwr+5lHG9H7DV49j oO08kq9InZzeejTP7TCV3GhUY4uWr2tWPJWP8DEaei+QMv1V/t0f2eTzRi+qddyz9lQBiL eh20cTsJLwg++6qR7gF+zAJ/TPi/0XoVwXEPwf5S7Px8rueYUyoy+JzcJ9yX/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771970949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qjSg0nUWnqHniJasF1oE2UqdJHsRJjdAFYnZMKLtJw0=; b=h+M+S0sbWVUfQzaP92Eo0418dE5jrKUqUriwbtacIc96EOxWtBU8hW4/WTvGQ5WzH+YVOt 4mCQr7ihOFTRR5TOXrYy2XdiY8eph1u/23Slwa5kq7zTbI5KSvbyiZ1Dd7+j0S5flwqV/O ZsTU1RYPYfnPre1hHSLUwAxhAQXz90TpQNjnLh5wMGLkgcjSGOf3ZzBlVaUMOVQtR5GdOa d307kmPckZu5vX/711+nOZemOYvVBbPi2kBNhwToUjFpObgMXmxj6ZNqv+P3QEpLj/V4R9 bWKwv//rvXmrUGpsltTT38lmP9sOnXIuox/R7s2uehQyQgkTTln6eOIDo1BkGA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fLBhP0WMzzZxd for ; Tue, 24 Feb 2026 22:09:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 37782 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 24 Feb 2026 22:09:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Bjoern A. Zeeb Subject: git: 5edf24aac1d0 - main - ofed: reduce usage of struct dma_attrs *dma_attrs List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5edf24aac1d0978d37d62594f42d87c9f118622b Auto-Submitted: auto-generated Date: Tue, 24 Feb 2026 22:09:09 +0000 Message-Id: <699e2185.37782.5dbfa03b@gitrepo.freebsd.org> The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=5edf24aac1d0978d37d62594f42d87c9f118622b commit 5edf24aac1d0978d37d62594f42d87c9f118622b Author: Bjoern A. Zeeb AuthorDate: 2026-02-19 23:12:29 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-02-24 22:04:36 +0000 ofed: reduce usage of struct dma_attrs *dma_attrs ib_verbs.h still uses struct dma_attrs *dma_attrs everywhere. It is beyond my knowledge when that struct got deprecated upstream but it is still supported by our LinuxKPI. The problem is that the functions called with that argument (dma_map_single_attrs, dma_unmap_single_attrs, dma_map_sg_attrs, dma_unmap_sg_attrs) so far are #defines in LinuxKPI and drop the last argument (attrs) so it was never a problem. In preparation to pass the attrs to the actual implementation in LinuxKPI, which has gained support for them, we now pass dma_sttrs->flags which is the expected unsigned long bit field. If anyone has serious interest in updating our ofed implementation they could look into this some more and remove the usage of struct dma_attrs entirely. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D55390 --- sys/ofed/include/rdma/ib_verbs.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/ofed/include/rdma/ib_verbs.h b/sys/ofed/include/rdma/ib_verbs.h index 78aa0af4fa2b..0c40a6f18f7c 100644 --- a/sys/ofed/include/rdma/ib_verbs.h +++ b/sys/ofed/include/rdma/ib_verbs.h @@ -3539,7 +3539,7 @@ static inline u64 ib_dma_map_single_attrs(struct ib_device *dev, struct dma_attrs *dma_attrs) { return dma_map_single_attrs(dev->dma_device, cpu_addr, size, - direction, dma_attrs); + direction, dma_attrs->flags); } static inline void ib_dma_unmap_single_attrs(struct ib_device *dev, @@ -3548,7 +3548,7 @@ static inline void ib_dma_unmap_single_attrs(struct ib_device *dev, struct dma_attrs *dma_attrs) { return dma_unmap_single_attrs(dev->dma_device, addr, size, - direction, dma_attrs); + direction, dma_attrs->flags); } /** @@ -3630,7 +3630,7 @@ static inline int ib_dma_map_sg_attrs(struct ib_device *dev, dma_attrs); else return dma_map_sg_attrs(dev->dma_device, sg, nents, direction, - dma_attrs); + dma_attrs->flags); } static inline void ib_dma_unmap_sg_attrs(struct ib_device *dev, @@ -3643,7 +3643,7 @@ static inline void ib_dma_unmap_sg_attrs(struct ib_device *dev, dma_attrs); else dma_unmap_sg_attrs(dev->dma_device, sg, nents, direction, - dma_attrs); + dma_attrs->flags); } /** * ib_sg_dma_address - Return the DMA address from a scatter/gather entry