Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Sep 2018 08:39:22 +0200
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Yuri Victorovich <yuri@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r479320 - in head: . net/charm
Message-ID:  <20180910063922.mkvyxu7z2mkxvigi@atuin.in.mat.cc>
In-Reply-To: <201809091703.w89H3u0v018715@repo.freebsd.org>
References:  <201809091703.w89H3u0v018715@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--f4bqb7ktwvbmt2qo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Sep 09, 2018 at 05:03:56PM +0000, Yuri Victorovich wrote:
> +RESTRICTED=3D	No commercial use: commercial use requires a commercial li=
cense
> +

You already have a LICENSE block, and if the LICENSE block does the
right thing this is not superfluous.

>  USES=3D		fortran gmake localbase:ldflags shebangfix tar
>  SHEBANG_GLOB=3D	*.sh
>  SHEBANG_FILES=3D	src/scripts/*
>  USE_LDCONFIG=3D	yes
> =20
> -GIT_URL=3D	https://charm.cs.illinois.edu/gerrit/charm.git
> -
>  ARCH_STR=3D	linux${ARCH:S/amd64/64/:S/i386/32/}
> =20
>  INSTALL_WRKSRC=3D	${WRKSRC}/${VERSION}-${ARCH_STR}-gfortran-clang/tmp
> @@ -49,20 +49,15 @@ MPI_VARS=3D		VERSION=3Dmpi
>  MPI_LDFLAGS=3D		-lmpich
>  MPI_LIB_DEPENDS=3D	libmpich.so:net/mpich2
> =20
> -local-makesum: # Workaround: the generic 'make makesum' is broken when c=
ustom do-fetch is defined: it calls ${SCRIPTSDIR}/do-fetch.sh.
> -	@${MAKE} distclean fetch makesum
> +.include <bsd.port.pre.mk>
> =20
> +.if !exists(${DISTDIR}/NAMD_2.12_Source.tar.gz)
> +IGNORE=3D	please download the release tarball of the version ${DISTVERSI=
ON} (${DISTFILES}) from https://www.ks.uiuc.edu/Development/Download/downlo=
ad.cgi?PackageName=3DNAMD, put it into ${DISTDIR}, and run 'make' again
> +.else
>  do-fetch:
> -	@if ! [ -f "${DISTDIR}/NAMD_2.12_Source.tar.gz" ]; then \
> -	  ${ECHO} "(!!)"; \
> -	  ${ECHO} "(!!) Please download the release tarball of the version 2.12=
 of NAMD (NAMD_2.12_Source.tar.gz)"; \
> -	  ${ECHO} "(!!) from https://www.ks.uiuc.edu/Development/Download/downl=
oad.cgi?PackageName=3DNAMD,"; \
> -	  ${ECHO} "(!!) put it into ${DISTDIR}, and run 'make' again."; \
> -	  ${ECHO} "(!!)"; \
> -	  ${FALSE}; \
> -	fi
>  	@${MKDIR} ${DISTDIR}/${DIST_SUBDIR}
>  	@cd ${DISTDIR}/${DIST_SUBDIR} && ${TAR} xf ${DISTDIR}/NAMD_2.12_Source.=
tar.gz --strip-components 1 NAMD_2.12_Source/charm-${DISTVERSION}.tar
> +.endif

This looks like it should be pre-extract, not do-fetch.

>  post-patch:
>  	@${REINPLACE_CMD} 's|which gfortran |which gfortran${GCC_DEFAULT} |' ${=
WRKSRC}/src/arch/common/conv-mach-gfortran.sh
> @@ -84,4 +79,4 @@ post-install:
>  .endfor
>  	@cd ${STAGEDIR} && ${MV} lib_so/* ./${PREFIX}/lib && ${RMDIR} lib_so
> =20
> -.include <bsd.port.mk>
> +.include <bsd.port.post.mk>
>=20
>=20

--=20
Mathieu Arnold

--f4bqb7ktwvbmt2qo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAluWEZpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkiTDA//as2kRxhKIKTD228z6isBIohYmdz7eACdV3jR96vxGZTLNDsNLtsrHjex
Bn6gxfIczGmDwmjP7HXWHEuSUqNIBQj3wJn7RvUnrsc7CEf+08UxuseeuJQGU1f4
9aAry+jxXeyvHQe/cbyEG3IplXQ00l4zBjlRWADwWcThY9sAz5X1AfPlX/mcrfcj
v9pVQSmVNmKThBrlMXStiluoxuIIpvQ6++wPYRQu/TLgCj76p3pr15ai6rptBlj0
tdgZnRyCE3DIxEwdP2JN9mVfuVI9H7/spFbzWiFTwuGbURO6I1Cr4c9mZJESIpPf
8rsXjpp7uRsngS3vnTNLnSQn33mXm5djByq62vPp02bj2K+my6JM5LWhVlczXheD
8OPKzS1/Nwwb0gXMkIYIe8wi0qCcJnrmHzO25+6+ZfJ0wbg8gpHWOPF6h3w524K2
MjA+w+U6Gxu9gvLTc6qpQVe/6irMveku+Ry5dGmLZqKaWgZx+JqEElbRwh7rNKwI
d8Hubj8hNSZfbUdmNrVsk+Se7YfjIkJWnL/LmMYKjBFtXrWqxyvCjkMaARJsnRk3
Ed3i+/EG/wy09iEfJz0PKJyHEA80CfPNFD9ye/d7R9JlsZPtHUsQSmWFzNRzMeUA
bZ0xMobd1SYzXhHBpe+S/o3Lk65KLCSgHhmY3+bdFjvDvNocF2Q=
=Kx2B
-----END PGP SIGNATURE-----

--f4bqb7ktwvbmt2qo--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180910063922.mkvyxu7z2mkxvigi>