Date: Sun, 01 Feb 2004 22:32:45 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Lukas Ertl <l.ertl@univie.ac.at> Cc: freebsd-geom@freebsd.org Subject: Re: Panic in g_disk_done() with atacontrol detach Message-ID: <718.1075671165@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 01 Feb 2004 22:29:54 %2B0100." <20040201222823.M616@korben.in.tern>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20040201222823.M616@korben.in.tern>, Lukas Ertl writes: >On Sun, 1 Feb 2004, Poul-Henning Kamp wrote: > >> In message <20040201190653.M613@korben.in.tern>, Lukas Ertl writes: >> >The problem obviously is that ad_detach() calls disk_destroy() which nulls >> >out the softc, and in g_disk_done() this softc is referenced again. >> > >> >The question is: is this an unsupported operation in the sense of "don't >> >do that"? If yes, then "atacontrol detach" should probably refuse to do >> >the actual detach when there are I/O requests running, this would prevent >> >a lot of foot shooting. >> >> No, this should work. > >Ok, but just commenting out the "gp->softc = NULL" statements apparently >aren't the way to go, cause then I end up in a panic somewhere in the >softupdate code... > >Any hints how to properly do this? I need to look a this in detail before I can answer, but the trick may be to move the removal of the devstat stuff earlier (ie: before the null'ing of the softc). -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?718.1075671165>