From nobody Thu Jun 4 17:55:36 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gWXKh1FCvz6gj4H for ; Thu, 04 Jun 2026 17:55:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gWXKh0bFGz4Hmd for ; Thu, 04 Jun 2026 17:55:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780595736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4IXgxVWE0ST2Km4EdC9k9SsARZuQ3vshyovykRNNcqY=; b=Ahy9NsqFsR/6U0Y2ajI882gSAXhdjCNnGHioenORQjzgq1bBa0Q+VIGLFBJxeyaAnZ88ft S0wwNEwyvwX/7dwfh7Fc2Z0DmIbNcDIWrLxX8pw+xXiJX7yxW2/25PUvPsCv4cfg/FUpOZ F0ziIL6gWePfCHmG1NgOY3POfDlEOyt/dDcEvPJzhoqmJugk0Ky4pZ/erG7IJ/edQ1xg0C sAx7otFtSmaw0DDtqsCGogT/IZ5CrVcq4bEa8zg/sZlN4w0iFf5bxRtCXt1qsrW07Pe+An OdjufJoCjBPFiJywgJcHDrlE4MtmxyaNhwx80Oad9/Qf4sa9eirhkfWiP5//eQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780595736; a=rsa-sha256; cv=none; b=m/rXbknrHekq3mdRsTJ4Xlcf/6nEPjICVs7DulztMowR9LakgWnL22oVdavDmtmH/twO/8 z+dyWmVIoJiIZ4H2tr0vORZZVyIYLlFDPlxa5W8+MCvedgL9sWipaTdF2W+obrjG81xjYR +saAo/hmFXDQkUBd1nrY3zk8a/X5tpcmcHEL6OfEc/cmq26shnlq8Vj3K7maXLSUPmeEkj sp8UqvGRhP6/MXP1lm1nweE+6M+YSW9JQ4LErG67Ci1p6sEQF4gsP+u20ZrO9RvkuUPaWQ 3C+qg1iUQomhzUaKDs/lLTxvdaCOZMGmbmyGCzfXw9jDexnGIgUoiBZIEoFo1g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780595736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4IXgxVWE0ST2Km4EdC9k9SsARZuQ3vshyovykRNNcqY=; b=r+ETiT1mlvrocGl005AbsGIyuQ3Q2sSHCtLhaodqBgOnaKTjslKaqGZFeiRo+tyQGl0uao 7Gp+Rez7GNbGA9gwg+Jb5Shd6H6Svfe88gm/NBsqkNOzSEfoc0brZ3RN7XAJRPs+kTRrXz d4jXL30fpVWOKZTunuZopZ6wg5dbA8w0sVPXNbZkPTolv6BFnrD/o7SAX94LQKxLVpyPSi +oENJBPHPTCoDe7x4KPMbWkrcJe4ZrfI0IzCG2lNlABLQYa4QhxlZ2QY/oGtdJM4NOJxtI nW7q/pTvBhP8IMs/D0SF9E1LAjFwL7Lt/8LUJhpsSg6oPD8vnWQeOk3U1uXdlw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gWXKh0B0vz17Sx for ; Thu, 04 Jun 2026 17:55:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2040e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 04 Jun 2026 17:55:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 453968c78d27 - main - uipc_usrreq: revert addition of EMPTYPATH for bindat(2) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 453968c78d27ed5c90562a1178f34fe8d616bf40 Auto-Submitted: auto-generated Date: Thu, 04 Jun 2026 17:55:36 +0000 Message-Id: <6a21bc18.2040e.38ce0e7e@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=453968c78d27ed5c90562a1178f34fe8d616bf40 commit 453968c78d27ed5c90562a1178f34fe8d616bf40 Author: Konstantin Belousov AuthorDate: 2026-06-04 17:26:09 +0000 Commit: Konstantin Belousov CommitDate: 2026-06-04 17:55:11 +0000 uipc_usrreq: revert addition of EMPTYPATH for bindat(2) The caller wants the parent vnode, which cannot be provided for emptypath lookups. Reported and reviewed by: markj Fixes: 12c590a9abd7 ("bindat(2)/connectat(2): allow implicit EMPTYPATH for unix domain sockets") Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D57448 --- lib/libsys/open.2 | 4 +--- sys/kern/uipc_usrreq.c | 5 ++--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/libsys/open.2 b/lib/libsys/open.2 index defc593b15ce..7915f7e8ef0a 100644 --- a/lib/libsys/open.2 +++ b/lib/libsys/open.2 @@ -447,11 +447,9 @@ The other functionality of the returned file descriptor is limited to the following descriptor-level operations: .Pp .Bl -tag -width __acl_aclcheck_fd -offset indent -compact -.It Xr bindat 2 -for unix domain socket -.Pq see Xr unix 4 .It Xr connectat 2 for unix domain socket +.Pq see Xr unix 4 .It Xr fcntl 2 but advisory locking is not allowed .It Xr dup 2 diff --git a/sys/kern/uipc_usrreq.c b/sys/kern/uipc_usrreq.c index a798aaf4f871..920588627914 100644 --- a/sys/kern/uipc_usrreq.c +++ b/sys/kern/uipc_usrreq.c @@ -612,9 +612,8 @@ uipc_bindat(int fd, struct socket *so, struct sockaddr *nam, struct thread *td) buf[namelen] = 0; restart: - NDINIT_ATRIGHTS(&nd, CREATE, NOFOLLOW | LOCKPARENT | NOCACHE | - EMPTYPATH, UIO_SYSSPACE, buf, fd, cap_rights_init_one(&rights, - CAP_BINDAT)); + NDINIT_ATRIGHTS(&nd, CREATE, NOFOLLOW | LOCKPARENT | NOCACHE, + UIO_SYSSPACE, buf, fd, cap_rights_init_one(&rights, CAP_BINDAT)); /* SHOULD BE ABLE TO ADOPT EXISTING AND wakeup() ALA FIFO's */ error = namei(&nd); if (error)