Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Dec 2023 08:30:23 GMT
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: e373880312fb - stable/14 - libc: correct some memory leaks in acl_to_text(3) and acl_to_text_np(3)
Message-ID:  <202312200830.3BK8UNSM033582@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=e373880312fb8ea09c501975e1fd23234a0df1e3

commit e373880312fb8ea09c501975e1fd23234a0df1e3
Author:     Peter Eriksson <pen@lysator.liu.se>
AuthorDate: 2023-12-17 22:03:13 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2023-12-20 08:29:55 +0000

    libc: correct some memory leaks in acl_to_text(3) and acl_to_text_np(3)
    
    PR:     275232
    
    (cherry picked from commit 7aa375dcc61e48cc56da45c9d5a11371693c8043)
---
 lib/libc/posix1e/acl_to_text_nfs4.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/libc/posix1e/acl_to_text_nfs4.c b/lib/libc/posix1e/acl_to_text_nfs4.c
index d901b1cf6b88..157215c9dd52 100644
--- a/lib/libc/posix1e/acl_to_text_nfs4.c
+++ b/lib/libc/posix1e/acl_to_text_nfs4.c
@@ -72,6 +72,7 @@ format_who(char *str, size_t size, const acl_entry_t entry, int numeric)
 			snprintf(str, size, "user:%d", (unsigned int)*id);
 		else
 			snprintf(str, size, "user:%s", pwd->pw_name);
+		acl_free(id);
 		break;
 
 	case ACL_GROUP_OBJ:
@@ -91,6 +92,7 @@ format_who(char *str, size_t size, const acl_entry_t entry, int numeric)
 			snprintf(str, size, "group:%d", (unsigned int)*id);
 		else
 			snprintf(str, size, "group:%s", grp->gr_name);
+		acl_free(id);
 		break;
 
 	case ACL_EVERYONE:
@@ -157,6 +159,7 @@ format_additional_id(char *str, size_t size, const acl_entry_t entry)
 		if (id == NULL)
 			return (-1);
 		snprintf(str, size, ":%d", (unsigned int)*id);
+		acl_free(id);
 	}
 
 	return (0);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202312200830.3BK8UNSM033582>