From owner-freebsd-bugs@freebsd.org Sat Mar 9 11:13:47 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE7C11541BE9 for ; Sat, 9 Mar 2019 11:13:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 87C1882236 for ; Sat, 9 Mar 2019 11:13:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 4AF4D1541BE5; Sat, 9 Mar 2019 11:13:46 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 382C41541BE4 for ; Sat, 9 Mar 2019 11:13:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C2EC682233 for ; Sat, 9 Mar 2019 11:13:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 09887E09D for ; Sat, 9 Mar 2019 11:13:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x29BDiME016078 for ; Sat, 9 Mar 2019 11:13:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x29BDiAu016077 for bugs@FreeBSD.org; Sat, 9 Mar 2019 11:13:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 208445] /usr/sbin/service: WARNING: $xyz is not set properly - see rc.conf(5). Date: Sat, 09 Mar 2019 11:13:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: misc-freebsd-bugzilla@talk2dom.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Mar 2019 11:13:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D208445 misc-freebsd-bugzilla@talk2dom.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc-freebsd-bugzilla@talk2 | |dom.com --- Comment #3 from misc-freebsd-bugzilla@talk2dom.com --- Still present in FreeBSD12.0-RELEASE "$ is not set properly" ... is caused by this in /etc/rc.d/addswap: rcvar=3D and this code in service(8): eval `grep ^rcvar $file` if [ -n "$rcvar" ]; then load_rc_config_var ${name} ${rcvar} fi checkyesno $rcvar 2>/dev/null && echo $file So although service(8) checks whether $rcvar has non-zero length (-n), it s= till goes on to use it with checkyesno (from /etc/rc.subr) which emits the warni= ng. Other /etc/rc.d scripts with empty rcvar, like dhclient, have "nostart" in their keywords so are not considered by service(8) thanks to it calling rcorder(8) with "-s nostart" That's the 'why' but I don't know enough to say whether the fix should be: 1. move checkyesno inside the if-block for service(8) 2. change checkyesno to remove warning if arg (rcvar) is unset/empty 3. add "nostart" keyword /etc/rc.d/addswap --=20 You are receiving this mail because: You are the assignee for the bug.=