From owner-freebsd-current@freebsd.org Thu May 25 16:22:06 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 407F0D81CD0 for ; Thu, 25 May 2017 16:22:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 29AEA185E for ; Thu, 25 May 2017 16:22:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 28FBFD81CCF; Thu, 25 May 2017 16:22:06 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 289F3D81CCE for ; Thu, 25 May 2017 16:22:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AACA9185C; Thu, 25 May 2017 16:22:05 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v4PGM0h1047289 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 25 May 2017 19:22:00 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v4PGM0h1047289 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v4PGM0Fw047288; Thu, 25 May 2017 19:22:00 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 25 May 2017 19:22:00 +0300 From: Konstantin Belousov To: Don Lewis Cc: current@freebsd.org Subject: Re: ino64 package fallout Message-ID: <20170525162200.GX1622@kib.kiev.ua> References: <20170524171326.GQ1622@kib.kiev.ua> <201705250049.v4P0n40X070175@gw.catspoiler.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201705250049.v4P0n40X070175@gw.catspoiler.org> User-Agent: Mutt/1.8.2 (2017-04-18) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2017 16:22:06 -0000 On Wed, May 24, 2017 at 05:49:04PM -0700, Don Lewis wrote: > On 24 May, Konstantin Belousov wrote: > > On Wed, May 24, 2017 at 10:05:22AM -0700, Don Lewis wrote: > >> I just upgraded by package build box and its poudriere jail to r318776 > >> and ran into some significant package build fallout. > > > > There are several reviews that fix ports with most significant fallouts, > > lang/llvm39 D10796 > > lang/llvm40 D10797 > > lang/ghc D10798 > > multimedia/webcamd D10800 > > devel/libgtop D10795 > > sysutils/py-psutil D1081 > > lang/rust D10799 > > > > I intend to commit this tomorrow, after the ino64 get some probation time, > > long enough to ensure that it does not get immediate revert. You may > > see the discussions and use the patches locally, meantime. > > devel/libgtop is also broken: > > procopenfiles.c:325:39: error: no member named 'kf_sa_local' in 'struct kinfo_file' > sun = (struct sockaddr_un *)&kif->kf_sa_local; > ~~~ ^ > procopenfiles.c:330:37: error: no member named 'kf_sa_local' in 'struct kinfo_file' > addrstr = addr_to_string(&kif->kf_sa_local); > ~~~ ^ > procopenfiles.c:338:37: error: no member named 'kf_sa_peer' in 'struct kinfo_file' > addrstr = addr_to_string(&kif->kf_sa_peer); > ~~~ ^ > procopenfiles.c:352:36: error: no member named 'kf_sa_peer' in 'struct kinfo_file' > addrstr = addr_to_string(&kif->kf_sa_peer); > ~~~ ^ > procopenfiles.c:357:52: error: no member named 'kf_sa_peer' in 'struct kinfo_file' > entry.info.sock.dest_port = addr_to_port(&kif->kf_sa_peer); > procwd.c:155:16: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare] > for (i = 0; i < len / sizeof(*kif); i++, kif++) { > ~ ^ ~~~~~~~~~~~~~~~~~~ > ~~~ ^ > procopenfiles.c:388:9: warning: cast from 'gchar *' (aka 'char *') to 'glibtop_open_files_entry *' (aka 'struct _glibtop_open_files_entry *') increases required alignment from 1 to 4 [-Wcast-align] > return (glibtop_open_files_entry*)g_array_free(entries, FALSE); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > procopenfiles.c:305:16: warning: comparison of integers of different signs: 'ssize_t' (aka 'long') and 'unsigned long' [-Wsign-compare] > for (i = 0; i < len / sizeof(*kif); i++, kif++) { > ~ ^ ~~~~~~~~~~~~~~~~~~ > 2 warnings and 5 errors generated. This looks like errors from the unpatched port. For instance, in my working directory, content of the file devel/libgtop/work/libgtop-2.32.0/sysdeps/freebsd/procopenfiles.c around line 325 is: struct sockaddr_un *sun; entry.type = GLIBTOP_FILE_TYPE_LOCALSOCKET; sun = (struct sockaddr_un *)&kif->kf_un.kf_sock. kf_sa_local; which is not sun = (struct sockaddr_un *)&kif->kf_sa_local; as reported by compiler in your case. The patch is applied as extra-patch, might be you have OSVERSION set forcibly ?