From owner-p4-projects@FreeBSD.ORG Tue Sep 23 18:00:24 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A64D11065673; Tue, 23 Sep 2008 18:00:24 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 699BC106566C for ; Tue, 23 Sep 2008 18:00:24 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3CDC48FC1B for ; Tue, 23 Sep 2008 18:00:24 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id m8NI0OYA096224 for ; Tue, 23 Sep 2008 18:00:24 GMT (envelope-from ed@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id m8NI0OA9096222 for perforce@freebsd.org; Tue, 23 Sep 2008 18:00:24 GMT (envelope-from ed@FreeBSD.org) Date: Tue, 23 Sep 2008 18:00:24 GMT Message-Id: <200809231800.m8NI0OA9096222@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to ed@FreeBSD.org using -f From: Ed Schouten To: Perforce Change Reviews Cc: Subject: PERFORCE change 150363 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2008 18:00:24 -0000 http://perforce.freebsd.org/chv.cgi?CH=150363 Change 150363 by ed@ed_dull on 2008/09/23 17:59:43 Maybe a little safer: make sure we only allow hooks to be set on cdevs that use ttydev_cdevsw instead of relying on D_TTY. Affected files ... .. //depot/projects/mpsafetty/sys/kern/tty.c#43 edit Differences ... ==== //depot/projects/mpsafetty/sys/kern/tty.c#43 (text+ko) ==== @@ -1690,7 +1690,7 @@ cdp = dev_refthread(dev); if (cdp == NULL) goto done1; - if ((cdp->d_flags & D_TTY) == 0) + if (cdp != &ttydev_cdevsw) goto done2; tp = dev->si_drv1;