Date: Mon, 01 Oct 2018 23:37:25 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 231870] ports-mgmt/portint: Bogus warnings about extra items placed in the USES/USE_x section Message-ID: <bug-231870-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D231870 Bug ID: 231870 Summary: ports-mgmt/portint: Bogus warnings about extra items placed in the USES/USE_x section Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: tobik@freebsd.org With something like (see editors/ghostwriter for an example port) USES=3D ... USE_GITHUB=3D yes GH_ACCOUNT=3D blabla portlint -AC wrongly complains WARN: Makefile: extra item placed in the USES/USE_x section, for exampl= e, "GH_ACCOUNT". 0 fatal errors and 1 warning found. This is contrary to what's suggested in the Porter's Handbook [1] where it says Keep related variables close together. For example, if using USE_GITHUB, always put the GH_* variables right after it. Also see the example Makefile at [2]. [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-uses.ht= ml [2] https://www.freebsd.org/doc/en/books/porters-handbook/porting-samplem.h= tml --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-231870-7788>