Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Jul 2019 05:53:13 +0000 (UTC)
From:      Sean Chittenden <seanc@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r349937 - head/usr.sbin/bhyve
Message-ID:  <201907120553.x6C5rDxE042066@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: seanc (ports committer)
Date: Fri Jul 12 05:53:13 2019
New Revision: 349937
URL: https://svnweb.freebsd.org/changeset/base/349937

Log:
  usr.sbin/bhyve: unconditionally initialize the NVMe completion status
  
  Follow-up work to improve the handling of unsupported/invalid opcodes
  is being developed by chuck@.
  
  Coverity CID:	1398928
  Reviewed by:	chuck
  Approved by:	araujo, imp
  Differential Revision:	https://reviews.freebsd.org/D20914

Modified:
  head/usr.sbin/bhyve/pci_nvme.c

Modified: head/usr.sbin/bhyve/pci_nvme.c
==============================================================================
--- head/usr.sbin/bhyve/pci_nvme.c	Fri Jul 12 05:35:45 2019	(r349936)
+++ head/usr.sbin/bhyve/pci_nvme.c	Fri Jul 12 05:53:13 2019	(r349937)
@@ -978,6 +978,7 @@ pci_nvme_handle_admin_cmd(struct pci_nvme_softc* sc, u
 	
 	while (sqhead != atomic_load_acq_short(&sq->tail)) {
 		cmd = &(sq->qbase)[sqhead];
+		compl.cdw0 = 0;
 		compl.status = 0;
 
 		switch (cmd->opc) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201907120553.x6C5rDxE042066>