From nobody Fri Sep 27 13:00:14 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XFVtk34m3z5XykP; Fri, 27 Sep 2024 13:00:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XFVtk2b1zz4wKF; Fri, 27 Sep 2024 13:00:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727442014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nmR544VIpS2A6jsXZ8wgIEzK0Y22Udd5Vwcnm4BbJ/s=; b=cYK/4FKSp5oiiI17agidjE0PkH3ALDRXRjqyaLsFIWU+tiQhDwCKTkuwbvCO6AbE+4TEP7 lEZUVbyc2WJ+MbqeZqxcy28gQFMCauQcbbuz62+/upkzQZjoD3FImoX9fBuuOCbPflEwLu LuDZ/cdHgBLarSb38VFvsgpVZ2UKeuAXP0ZnZ1Wbhb4CXSPQTGxtB8nM+aSD8vg0P2o2CV in5rabe9LyGxMzxvyHAq4Whz7538zmpwyzDnNQK3AMs1cFFvVS5VJjg/A42fY8x6EYawIr bPjre6Ho/yb2jqW49hRAsecyNKhXb5qMVf2pONn1ZIRLH8+fdKmw0+Zi3himtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727442014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nmR544VIpS2A6jsXZ8wgIEzK0Y22Udd5Vwcnm4BbJ/s=; b=uyNYYFyO+S4dJkjHxXuwiFzIqUOCyeckpn2MG79ce8zo7Oo6IyxzHZTBcdZzTIbIf+7R5v vQL2V5/Tb3ekOF57ZWwinbztl/LGP/a2RB7knxXpA7hb4++6CwdEfdjJyRrb4KXrbGbQGK +6bkyu5hXZfpmWBwuvjbJTNUhZNgzp/YFWBzA/at3/Xtvor7gTmaILHFlABW9WfM0aL1zp 3ZrWVUEBo1k289sdqZAHj9Sf5ARNtXaXa0gI8UoqUOv9LgO2EJ2dIlDFw5JNAgo525x5TP S3cdLgzup2fjU8odhJXROAD7INTUy/TsZz0Btu9EmX4yRjV3z4Ku3wZky6J8qg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727442014; a=rsa-sha256; cv=none; b=hM4/YyGgY9wiyv+tuK40PHuv2jzLcys7o8kMQZb72CRw7tvE5zjy2TZlKL+tNUjin8ANaz YvEmPUNgiVOSTUm3xm4cdiIHsKfBrILvlDGwnJgNoIGKyKfqx4BFp+kRVVgQYuuYLgB/zA fBH/6GQMFXHVVXEMnK5+F43u+rcQGFT01GNVyEYNAtfVLzvJoRi4oFRmLSGNKH+XlQkGvH XFfqmDUPs04VSzB80SkNdoOKPrxd+m6Sk49J8eYjWjBHsAjCg2qyyey6Sj/4cleRYRXdso nsfxo1E16mfGARKekhFN+q57EAr4ThhBuxBE89b8M9Z6RelJmXnS+2N7cCgP6g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XFVtk2BJvzhck; Fri, 27 Sep 2024 13:00:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48RD0EtD095741; Fri, 27 Sep 2024 13:00:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48RD0Em6095732; Fri, 27 Sep 2024 13:00:14 GMT (envelope-from git) Date: Fri, 27 Sep 2024 13:00:14 GMT Message-Id: <202409271300.48RD0Em6095732@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 94693ec7c853 - main - bhyve: initialize register value List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 94693ec7c85363f9b0098247489cea3efdb183f9 Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=94693ec7c85363f9b0098247489cea3efdb183f9 commit 94693ec7c85363f9b0098247489cea3efdb183f9 Author: Pierre Pronchery AuthorDate: 2024-07-24 19:33:26 +0000 Commit: Ed Maste CommitDate: 2024-09-27 12:59:36 +0000 bhyve: initialize register value In case of an error in a code pattern like ``` uint64_t val; error = memread(vcpu, gpa, &val, 1, arg); error = vie_update_register(vcpu, reg, val, size); ``` uninitialized stack data would be used. Reported by: Synacktiv Reviewed by: markj Security: HYP-21 Sponsored by: The Alpha-Omega Project Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46107 --- sys/amd64/vmm/vmm_ioport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/amd64/vmm/vmm_ioport.c b/sys/amd64/vmm/vmm_ioport.c index f036841f4e10..fc1ecab9f209 100644 --- a/sys/amd64/vmm/vmm_ioport.c +++ b/sys/amd64/vmm/vmm_ioport.c @@ -101,7 +101,7 @@ static int emulate_inout_port(struct vcpu *vcpu, struct vm_exit *vmexit, bool *retu) { ioport_handler_func_t handler; - uint32_t mask, val; + uint32_t mask, val = 0; int error; /*