From owner-cvs-all Tue Nov 27 13:38: 9 2001 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 2E80F37B416; Tue, 27 Nov 2001 13:38:02 -0800 (PST) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.5) with SMTP id fARLboi20504; Tue, 27 Nov 2001 16:37:50 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Tue, 27 Nov 2001 16:37:49 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Mike Barcroft Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Committer's guide policy on commit message contents In-Reply-To: <20011127163513.A12400@espresso.q9media.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 27 Nov 2001, Mike Barcroft wrote: > From the Committers Guide: "Do not waste space in the commit messages > explaining what you did. That is what cvs diff is for. Instead, tell > us why you did it." Ignoring, for a moment, any context -- I think this is actually not a good policy. In the event that there are complex or large changes being made, a brief summary of the changes, along with the rationale, is appropriate in the commit message. At least, that's my feeling :-). Is this something that would be worth changing? Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message