From owner-cvs-src@FreeBSD.ORG Thu Sep 29 18:45:02 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AEA9A16A41F; Thu, 29 Sep 2005 18:45:02 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7BF2343D48; Thu, 29 Sep 2005 18:45:02 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8TIj2Oq062002; Thu, 29 Sep 2005 18:45:02 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8TIj2R5062001; Thu, 29 Sep 2005 18:45:02 GMT (envelope-from rwatson) Message-Id: <200509291845.j8TIj2R5062001@repoman.freebsd.org> From: Robert Watson Date: Thu, 29 Sep 2005 18:45:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/kern subr_prf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2005 18:45:02 -0000 rwatson 2005-09-29 18:45:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/kern subr_prf.c Log: Merge subr_prof.c:1.119, 1.120, 1.121 from HEAD to RELENG_6: Acquire Giant in uprintf() and tprintf() due to the non-MPSAFEty of the tty code invoked from these functions. Correct age-old comments about uprintf()/tprintf() sleeping: they will never sleep. Unlike in the merge to RELENG_6, it is not necesary to acquire Giant in the NFS code, as the NFS client runs entirely under Giant in 5.x. Likewise, this is not a critical fix in 5.x as the vast majority of relevant calls to uprintf() are in the VFS code, which also runs with Giant in 5.x. However, there are some exposed code paths that make this MFC a good idea. Much useful feedback from: bde Approved by: re (scottl) Revision Changes Path 1.113.2.2 +13 -8 src/sys/kern/subr_prf.c