From owner-svn-src-head@FreeBSD.ORG Wed Oct 22 01:56:19 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BBA1C772 for ; Wed, 22 Oct 2014 01:56:19 +0000 (UTC) Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 894B7E2C for ; Wed, 22 Oct 2014 01:56:19 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id lj1so2627602pab.18 for ; Tue, 21 Oct 2014 18:56:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=4hjhXCq9e8nyFHZB5fXIi0xJ0bKWonGe8lPSTyvctRc=; b=RVxc6fQPN/0OxqimYmiSYuL8xAXb7CHZJxGU0U3C9m/wvt2wt5jKwjnKW9gQEJzI5S +Dfky8C01eKfJlvAYexCy8omuAg2HoHQkSfIquvXMNjyRlXHqfECgjbL7AITVdjnmOvR NkUIAkKnlf1togXhYZNqGb1KVx81DFJULLuiIfkHnxbdeU6oMHovaI90RBjPqVncLO9i SDbPCT3Z41lK5Aw6OSV7eeulyogn0qD6+0k6rbhAYuUbDqqHW7/crAFQltx7+jSszfvu DjW54yEXMRiwWT+8togG6btdn50VlWSdb1rVLvLq4YU1cYXDOZ64BPM/Wtk8NO4fhOZ/ RL0w== X-Gm-Message-State: ALoCoQkbmfXmAQyslHMW3YYeOmpoIf/3roTB8qTuJ5AFK9Dcw7/CL/wyxpOdgkWR4gbN+5Pzo9NL X-Received: by 10.66.139.106 with SMTP id qx10mr466599pab.138.1413942578011; Tue, 21 Oct 2014 18:49:38 -0700 (PDT) Received: from macintosh-c42c033c0b73.corp.netflix.com (dc1-prod.netflix.com. [69.53.236.251]) by mx.google.com with ESMTPSA id kv10sm636385pab.23.2014.10.21.18.49.36 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 Oct 2014 18:49:37 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_DB67DB47-1D9A-4BF9-97CB-4EFE6631F24D"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r273417 - head From: Warner Losh In-Reply-To: <86d29k28wh.fsf@nine.des.no> Date: Tue, 21 Oct 2014 19:49:33 -0600 Message-Id: <22788EC4-3BDF-40F3-ACAC-FA686ED21154@bsdimp.com> References: <201410212029.s9LKThT2074337@svn.freebsd.org> <86d29k28wh.fsf@nine.des.no> To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 01:56:19 -0000 --Apple-Mail=_DB67DB47-1D9A-4BF9-97CB-4EFE6631F24D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Oct 21, 2014, at 7:25 PM, Dag-Erling Sm=F8rgrav wrote: > Warner Losh writes: >> Author: imp >> Date: Tue Oct 21 20:29:42 2014 >> New Revision: 273417 >> URL: https://svnweb.freebsd.org/changeset/base/273417 >>=20 >> Log: >> You aren't allowed to test WITH_xxx or WITHOUT_xxx here, so remove = it. >> Even if you were allowed to test for it, the test makes no sense as = it >> always results in adding -DWITH_ATF unless WITH_ATF was already >> defined. But if MK_ATF !=3D no, then we know it was defined. This, = in >> turn, caused tools/build/options/makemake always think WITH_ATF is = the >> default, which removed control of that from sys.conf.mk. >>=20 >> To get the intent of the deleted comment, another mechanism is >> required, assuming that the intent of that comment is desirable. >=20 > This broke the paralell build. It prevents building lib/atf entirely = in > stage 4.3, so the programs in libexec/atf have nothing to link against > unless lib/atf just happens to get built before libexec/atf. That > almost never happens: lib and libexec are built in paralell, and = lib/atf > is one of the last items in lib whereas libexec/atf is one of the = first > items in libexec. >=20 > (on a side note, libatf doesn't need to be in _prebuild_libs, since no > other library depend on it) Yea, it was AFU. I=92ll fix this. I think we need to have a = MK_TESTS_SUPPORT that builds the libatf stuff when yes, and omits it when no, since we = don=92t want the tests building when we=92re building the 4.3 stage. Warner > DES > --=20 > Dag-Erling Sm=F8rgrav - des@des.no --Apple-Mail=_DB67DB47-1D9A-4BF9-97CB-4EFE6631F24D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJURw0uAAoJEGwc0Sh9sBEAkrgP/R5+U6/6T8k04jHhvPK8FKxy kwJ2yJcGpO3jCo0ky9xDLmtdA5bu0mSkSnG9peCE4pYhRZsWpBptXHOyf8Wd45m1 qnHLci3uPAyW7qy2RqZuQN/XNMr274wtbS3J1O2HURGi17pUT2PNJaJagP0ppZ2Y vP/923VRA9TuyuPifYXEO+QdmuEExrJy2ATfzqI40nulFXahGsm0BEY1+RqhBP6o tUu1S8ZrsXKKZBsSclFHync+WIDntPHSMMYQDmhiTNvqoLWFhBMKcNuEGSiOd1J7 6DgdBuGn+BmcjXovpGysZYMqaahz8+OFbEDEfPh4ADv1sL/JGEauDV5/kY12kOLX Ds9arPAbdAyi6xbLSZf4heTQ7Cc4oB3R08DqD0ATWb5bF7/gDXxR4MgVsNUq4hiH gnYmoBwsc0OKr5r83FjWSabUnPqvSLlNDqdhXY8YDMmbTVsep9VKQ8zHXoAcL+37 fk/QR/UU2llEy9hhDj1/0LBLMxz449w8ybQmIqRLz7Ghe3HYC2VSVIl9Z4KecGxG CF2/uTF9yU4TzToB+GBe8Tlc6qdziiERge6k8rNp9KArXz1fb0Cjq36HakGbUFNu 5KqzZ3pbWfNwcIRmMmhp5cfFWZx183VNxNsWY6FeCz8yItOfdOjek0gmkY8yBSmY BTKVIY7Hls7i1AcERrow =Rt/o -----END PGP SIGNATURE----- --Apple-Mail=_DB67DB47-1D9A-4BF9-97CB-4EFE6631F24D--