From owner-freebsd-gnome@freebsd.org Mon Jun 5 18:25:05 2017 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C2C1AFEC24 for ; Mon, 5 Jun 2017 18:25:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 03DF065316 for ; Mon, 5 Jun 2017 18:25:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id F4067AFEC22; Mon, 5 Jun 2017 18:25:04 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F3A27AFEC21 for ; Mon, 5 Jun 2017 18:25:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E1C5465315 for ; Mon, 5 Jun 2017 18:25:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v55IP4K0010178 for ; Mon, 5 Jun 2017 18:25:04 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 219608] print/freetype2 produces incorrect line spacing for some fonts Date: Mon, 05 Jun 2017 18:25:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jun 2017 18:25:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219608 --- Comment #12 from lightside --- (In reply to comment #11) > I tries the two line patch, but the excess spacing problem returned. > Looks like !error test fails and the latest patch is an effective noop. Strange, because it works in my case. I may recommend to close all mate-terminal instances and open it again for test. Possible, that previous libfreetype2.so library used from memory. Com= pare with some screenshot from 2.7.1 version for the same mate-terminal profile,= for example. As about the "if ( !error )" check, it used before access to ttsize->metrics->x_ppem in 2.8 version, for example: http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/src/truetype/t= tdriver.c?h=3DVER-2-8#n357 -8<-- if ( FT_IS_SCALABLE( size->face ) ) { error =3D tt_size_reset( ttsize, 0 ); #ifdef TT_USE_BYTECODE_INTERPRETER /* for the `MPS' bytecode instruction we need the point size */ if ( !error ) { FT_UInt resolution =3D ttsize->metrics->x_ppem > ttsize->metrics->y_ppem ? req->horiResolution : req->vertResolution; -->8- The 2.7.1 doesn't have such check: http://git.savannah.gnu.org/cgit/freetype/freetype2.git/tree/src/truetype/t= tdriver.c?h=3DVER-2-7-1#n355 -8<-- if ( FT_IS_SCALABLE( size->face ) ) { error =3D tt_size_reset( ttsize ); ttsize->root.metrics =3D ttsize->metrics; #ifdef TT_USE_BYTECODE_INTERPRETER /* for the `MPS' bytecode instruction we need the point size */ { FT_UInt resolution =3D ttsize->metrics.x_ppem > ttsize->metrics.y_= ppem ? req->horiResolution : req->vertResolution; -->8- The alternative method is to check for "if ( ttsize->metrics )", which also worked. --=20 You are receiving this mail because: You are the assignee for the bug.=