From owner-svn-src-all@freebsd.org Mon May 23 20:06:31 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C99B0B468CC; Mon, 23 May 2016 20:06:31 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: from mail-lb0-f195.google.com (mail-lb0-f195.google.com [209.85.217.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5DC0F1C0A; Mon, 23 May 2016 20:06:31 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: by mail-lb0-f195.google.com with SMTP id sh2so1621602lbb.2; Mon, 23 May 2016 13:06:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:subject:references:date:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=oEd4QYafbz9z3Xl+1dLHnAPuIU/dbYTVhxxMT5oSAmw=; b=de02PmPjSMjC6O0jX5+ZfBnxmWaONzdetSgcQx1GT3tL3E4kFEPciO+2hD/M9qunS9 gFxiM3ZtDtsOVLLhKPqHRJMAb3BlENPL1Q3qms1FdrkNO5oHMyQLC57eY6GhrJ9tuyz2 JmFHn6CZKHQzQsN8pr1tFd29o329Cd5pMFRwtns2+pMlW37u9F1ryyd7HvRzba+5A6pv vCaORYwM2V+y+UPQP0RfkON4B9BLS/1oNpViFETbzWmaH2Po09Hoy1Xwk65uU4OIXA29 V0ixfcAFXtGa9I+CC+W3NI/8BKIXKLMSfz32KhhfAmmXl/4U4iUnvyrIQBrC/JRaGhtV W34w== X-Gm-Message-State: ALyK8tL5C2aUkWixsgRMWO8wb4BEoaOYGdZbQ2SCV0LaWWsCk5XRgZZLfElY6dTvSEaOgw== X-Received: by 10.112.170.161 with SMTP id an1mr2071787lbc.44.1464033982907; Mon, 23 May 2016 13:06:22 -0700 (PDT) Received: from localhost (host-176-37-109-22.la.net.ua. [176.37.109.22]) by smtp.gmail.com with ESMTPSA id r3sm6017528lbj.26.2016.05.23.13.06.21 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 23 May 2016 13:06:22 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, "Allan Jude" Subject: Re: svn commit: r298946 - head/usr.sbin/bsdinstall/scripts References: <201605022140.u42LeYFK051507@repo.freebsd.org> <186c070f-eb81-370d-b215-1d9f370918b8@freebsd.org> Date: Mon, 23 May 2016 23:06:16 +0300 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Andriy Voskoboinyk" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.16 (FreeBSD) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2016 20:06:31 -0000 Mon, 23 May 2016 08:00:27 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Allan Jude = : > On 2016-05-23 00:49, Allan Jude wrote: >> On 2016-05-02 17:40, Andriy Voskoboinyk wrote: >>> Author: avos >>> Date: Mon May 2 21:40:34 2016 >>> New Revision: 298946 >>> URL: https://svnweb.freebsd.org/changeset/base/298946 >>> >>> Log: >>> bsdinstall: fix static address assignment for protected wireless = >>> networks. >>> >>> Filter out IFCONFIG_PREFIX variable (which may contain WPA keyword= ) >>> from ifconfig parameters. >>> >>> PR: 169199 >>> >>> Modified: >>> head/usr.sbin/bsdinstall/scripts/netconfig_ipv4 >>> >>> Modified: head/usr.sbin/bsdinstall/scripts/netconfig_ipv4 >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >>> --- head/usr.sbin/bsdinstall/scripts/netconfig_ipv4 Mon May 2 = >>> 21:23:05 2016 (r298945) >>> +++ head/usr.sbin/bsdinstall/scripts/netconfig_ipv4 Mon May 2 = >>> 21:40:34 2016 (r298946) >>> @@ -84,7 +84,7 @@ retval=3D$? >>> >>> if [ "$BSDINSTALL_CONFIGCURRENT" ]; then >>> . $BSDINSTALL_TMPETC/._rc.conf.net >>> - ifconfig $INTERFACE `eval echo \\\$ifconfig_$INTERFACE` >>> + ifconfig $INTERFACE `eval echo \\\$ifconfig_$INTERFACE | sed = >>> "s|$2||"` >>> if [ "$defaultrouter" ]; then >>> route delete -inet default >>> route add -inet default $defaultrouter >>> >> >> This breaks static assignment of IP addresses to wired interfaces: >> >> sed: first RE may not be empty >> >> > > I wrote this patch for the issue. Unless you see a better way to do it= ? > > No, I have no better ideas.