From owner-cvs-sys Thu May 29 02:07:05 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id CAA03905 for cvs-sys-outgoing; Thu, 29 May 1997 02:07:05 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id CAA03888; Thu, 29 May 1997 02:06:35 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id TAA03442; Thu, 29 May 1997 19:03:01 +1000 Date: Thu, 29 May 1997 19:03:01 +1000 From: Bruce Evans Message-Id: <199705290903.TAA03442@godzilla.zeta.org.au> To: cvs-all@freebsd.org, cvs-committers@freebsd.org, cvs-sys@freebsd.org, peter@freebsd.org Subject: Re: cvs commit: src/sys/sys systm.h Sender: owner-cvs-sys@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > Modified files: > sys/sys systm.h > Log: > forward declare struct timeval so that pcibus.c doesn't get a warning. > (it doesn't #include since it doesn't need it) Actually, it should have #included either , or #included instead of , because was a prerequisite of . This prerequisite is obfuscated by #including in of KERNEL is defined. Most kernel sources/authors don't notice the problem because they #include without thought (#including both is a style error - see style(9)). Some kernel sources didn't #include even when they did need it. I have fixed some of these. Bruce