From owner-freebsd-testing@FreeBSD.ORG Wed Apr 9 22:57:10 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1936FE9A; Wed, 9 Apr 2014 22:57:10 +0000 (UTC) Received: from mail-ve0-x22f.google.com (mail-ve0-x22f.google.com [IPv6:2607:f8b0:400c:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BAFE41F9E; Wed, 9 Apr 2014 22:57:09 +0000 (UTC) Received: by mail-ve0-f175.google.com with SMTP id oz11so2730440veb.34 for ; Wed, 09 Apr 2014 15:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=+zinAmUcoFJzX6Nr9D0+IpbF86tVNgxdXvISDjfwT10=; b=Mq6Sej00f6F91IF/PcMBI2YCRrM2khMM56Adwr8JmTuVbDCyJY+8VOatQxEmRForjC y8qxf9+DZJ0tiGGSphcs2fjahF8u/NFlbvXCsw4PiaWpWck2vAqPrlGkh3C4hpUmDg4y Y9TfNFbq3zCLsqf2+90sgmpQ/6KelPaqNKGzOD07iGgiBgHbUlhyJxTHjrYjNzIBLONz FC+B9M1UbYq8bGlW7PXSAiAf5Ddawb6Ym2LqHMtwEqmXVHnKrCfrYMu8AYqQd47sIyoo fth8AkV29NQEv0wdGNkJ/5c0NuwzCD3BoViEIdRvuZcp6IBMDR5Ga7h+5Mp9/2kOFpj9 lsgA== MIME-Version: 1.0 X-Received: by 10.58.202.133 with SMTP id ki5mr10803181vec.19.1397084228900; Wed, 09 Apr 2014 15:57:08 -0700 (PDT) Received: by 10.221.67.136 with HTTP; Wed, 9 Apr 2014 15:57:08 -0700 (PDT) In-Reply-To: <16437CC5729B5345AF77F816513376E820BAE6A1@MX103CL02.corp.emc.com> References: <16437CC5729B5345AF77F816513376E820BAE6A1@MX103CL02.corp.emc.com> Date: Wed, 9 Apr 2014 15:57:08 -0700 Message-ID: Subject: Re: Diff to fix pjdfstest tests From: Garrett Cooper To: "Peel, Casey" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-testing@freebsd.org" , Pawel Jakub Dawidek X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Apr 2014 22:57:10 -0000 (CCing the maintainer, pjd@) On Wed, Apr 9, 2014 at 3:51 PM, Peel, Casey wrote: > In attempting to get pjdfstest working I found that some of the tests hav= e easily-corrected failures: > > One of which is a plan error: ftruncate/00.t runs 26 tests but only speci= fies 21 in the plan. > > Tests that create a small memory disk and fill it to ENOSPC don't validat= e that the memory disk mounts and will happily attempt to fill up your real= partition. The core of the failing is that the memory disk isn't large eno= ugh for the subsequent newfs to succeed and thus the mount fails. > > vbox1009# mdconfig -a -n -t malloc -s 256k > 0 > vbox1009# newfs /dev/md0 > /dev/md0: 0.2MB (512 sectors) block size 32768, fragment size 4096 > using 1 cylinder groups of 0.25MB, 8 blks, 128 inodes. > super-block backups (for fsck -b #) at: > 192 > first cylinder group ran out of space > vbox1009# mount /dev/md0 /mnt > mount: /dev/md0: Invalid argument > vbox1009# > > I've increased the size of the memdisk and added a hard exit to the test = if the mount fails. > > The open/16.t tests are all failing. The tests expect a ELOOP exit code b= ut I'm getting EMLINK. I haven't validated if this is a test error or an er= ror on the not-exactly-FreeBSD-10 code I'm running, so I haven't included t= hose tests in this diff and just made them TODO in my code until I figure i= t out. > > root # prove -r --nocount /svn/branch/src/tools/regression/pjdfstest/test= s > > All tests successful. > Files=3D206, Tests=3D12100, 839 wallclock secs ( 3.04 usr 2.71 sys + 40.= 46 cusr 374.61 csys =3D 420.82 CPU) > Result: PASS > root # Have you looked at what I did on https://github.com/yaneurabeya/pjdfstest (in particular I was working on the onefs branch back when I was with EMC)? The EMLINK issue was a known problem with the tests: https://github.com/yaneurabeya/pjdfstest/commit/8035e2c5b9ea505ec42cd2f2aad= 69f4d40cd2a6d . There are some other commits you probably want to grab and apply to the local tree after validating them: https://github.com/yaneurabeya/pjdfstest/commits/master . It would be nice if these were in the upstream github repo/in FreeBSD, but I didn't get around to setting up a pull request. I'll see about doing that now. Cheers, -Garrett