From owner-cvs-src@FreeBSD.ORG Sun Jun 11 20:32:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F1F7116A41A; Sun, 11 Jun 2006 20:32:18 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id BC78E43D79; Sun, 11 Jun 2006 20:32:10 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.62 (FreeBSD)) (envelope-from ) id 1FpWbR-000K1p-1S; Sun, 11 Jun 2006 21:32:09 +0100 Date: Sun, 11 Jun 2006 21:32:08 +0100 From: Ceri Davies To: Maxim Konovalov Message-ID: <20060611203208.GL23618@submonkey.net> Mail-Followup-To: Ceri Davies , Maxim Konovalov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200606112017.k5BKHItt056114@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GcSOTaE82DYSpZPK" Content-Disposition: inline In-Reply-To: <200606112017.k5BKHItt056114@repoman.freebsd.org> X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/cron/cron do_command.c popen.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Jun 2006 20:32:19 -0000 --GcSOTaE82DYSpZPK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 11, 2006 at 08:17:18PM +0000, Maxim Konovalov wrote: > maxim 2006-06-11 20:17:18 UTC >=20 > FreeBSD src repository >=20 > Modified files: > usr.sbin/cron/cron do_command.c popen.c=20 > Log: > o Spell "privledges" correctly. Re-style comment. Umm, it's "privileges". Ceri > | --- src/usr.sbin/cron/cron/do_command.c 2006/06/01 15:03:06 1.24 > | +++ src/usr.sbin/cron/cron/do_command.c 2006/06/11 20:17:18 1.25 > | @@ -17,7 +17,7 @@ > | =20 > | #if !defined(lint) && !defined(LINT) > | static const char rcsid[] =3D > | - "$FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/usr.sbin/cron/cron/do_= command.c,v 1.24 2006/06/01 15:03:06 maxim Exp $"; > | + "$FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/usr.sbin/cron/cron/do_= command.c,v 1.25 2006/06/11 20:17:18 maxim Exp $"; > | #endif > | =20 > | =20 > | @@ -243,7 +243,7 @@ child_process(e, u) > | (void) endpwent(); > | # endif > | /* set our directory, uid and gid. Set gid first, > | - * since once we set uid, we've lost root privledges. > | + * since once we set uid, we've lost root priviledges. > | */ > | if (setgid(e->gid) !=3D 0) { > | log_it(usernm, getpid(), > http://cvsweb.FreeBSD.org/src/usr.sbin/cron/cron/popen.c.diff?r1=3D1.13&r= 2=3D1.14 > | =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > | RCS file: /usr/local/www/cvsroot/FreeBSD/src/usr.sbin/cron/cron/popen.c= ,v > | retrieving revision 1.13 > | retrieving revision 1.14 > | diff -u -p -r1.13 -r1.14 > | --- src/usr.sbin/cron/cron/popen.c 2006/06/01 15:03:06 1.13 > | +++ src/usr.sbin/cron/cron/popen.c 2006/06/11 20:17:18 1.14 > | @@ -28,7 +28,7 @@ > | static char sccsid[] =3D "@(#)popen.c 5.7 (Berkeley) 2/14/89"; > | #endif > | static const char rcsid[] =3D > | - "$FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/usr.sbin/cron/cron/pop= en.c,v 1.13 2006/06/01 15:03:06 maxim Exp $"; > | + "$FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/usr.sbin/cron/cron/pop= en.c,v 1.14 2006/06/11 20:17:18 maxim Exp $"; > | #endif /* not lint */ > | =20 > | #include "cron.h" > | @@ -172,8 +172,10 @@ cron_popen(program, type, e) > | /* fall back to the old method */ > | (void) endpwent(); > | # endif > | - /* set our directory, uid and gid. Set gid first, > | - * since once we set uid, we've lost root privledges. > | + /* > | + * Set our directory, uid and gid. Set gid > | + * first since once we set uid, we've lost > | + * root priviledges. > | */ > | if (setgid(e->gid) !=3D 0) > | _exit(ERROR_EXIT); --=20 That must be wonderful! I don't understand it at all. -- Moliere --GcSOTaE82DYSpZPK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEjH3IocfcwTS3JF8RAjPTAJ9J99JffLEOiH1HlmGAv9vjNVn3MgCfYCQs 4PWepwS4zR89ZOxpeS1qnLY= =4wEU -----END PGP SIGNATURE----- --GcSOTaE82DYSpZPK--