Date: Sun, 11 Jun 2006 21:32:08 +0100 From: Ceri Davies <ceri@submonkey.net> To: Maxim Konovalov <maxim@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/cron/cron do_command.c popen.c Message-ID: <20060611203208.GL23618@submonkey.net> In-Reply-To: <200606112017.k5BKHItt056114@repoman.freebsd.org> References: <200606112017.k5BKHItt056114@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--GcSOTaE82DYSpZPK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Jun 11, 2006 at 08:17:18PM +0000, Maxim Konovalov wrote:
> maxim 2006-06-11 20:17:18 UTC
>=20
> FreeBSD src repository
>=20
> Modified files:
> usr.sbin/cron/cron do_command.c popen.c=20
> Log:
> o Spell "privledges" correctly. Re-style comment.
Umm, it's "privileges".
Ceri
> | --- src/usr.sbin/cron/cron/do_command.c 2006/06/01 15:03:06 1.24
> | +++ src/usr.sbin/cron/cron/do_command.c 2006/06/11 20:17:18 1.25
> | @@ -17,7 +17,7 @@
> | =20
> | #if !defined(lint) && !defined(LINT)
> | static const char rcsid[] =3D
> | - "$FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/usr.sbin/cron/cron/do_=
command.c,v 1.24 2006/06/01 15:03:06 maxim Exp $";
> | + "$FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/usr.sbin/cron/cron/do_=
command.c,v 1.25 2006/06/11 20:17:18 maxim Exp $";
> | #endif
> | =20
> | =20
> | @@ -243,7 +243,7 @@ child_process(e, u)
> | (void) endpwent();
> | # endif
> | /* set our directory, uid and gid. Set gid first,
> | - * since once we set uid, we've lost root privledges.
> | + * since once we set uid, we've lost root priviledges.
> | */
> | if (setgid(e->gid) !=3D 0) {
> | log_it(usernm, getpid(),
> http://cvsweb.FreeBSD.org/src/usr.sbin/cron/cron/popen.c.diff?r1=3D1.13&r=
2=3D1.14
> | =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> | RCS file: /usr/local/www/cvsroot/FreeBSD/src/usr.sbin/cron/cron/popen.c=
,v
> | retrieving revision 1.13
> | retrieving revision 1.14
> | diff -u -p -r1.13 -r1.14
> | --- src/usr.sbin/cron/cron/popen.c 2006/06/01 15:03:06 1.13
> | +++ src/usr.sbin/cron/cron/popen.c 2006/06/11 20:17:18 1.14
> | @@ -28,7 +28,7 @@
> | static char sccsid[] =3D "@(#)popen.c 5.7 (Berkeley) 2/14/89";
> | #endif
> | static const char rcsid[] =3D
> | - "$FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/usr.sbin/cron/cron/pop=
en.c,v 1.13 2006/06/01 15:03:06 maxim Exp $";
> | + "$FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/usr.sbin/cron/cron/pop=
en.c,v 1.14 2006/06/11 20:17:18 maxim Exp $";
> | #endif /* not lint */
> | =20
> | #include "cron.h"
> | @@ -172,8 +172,10 @@ cron_popen(program, type, e)
> | /* fall back to the old method */
> | (void) endpwent();
> | # endif
> | - /* set our directory, uid and gid. Set gid first,
> | - * since once we set uid, we've lost root privledges.
> | + /*
> | + * Set our directory, uid and gid. Set gid
> | + * first since once we set uid, we've lost
> | + * root priviledges.
> | */
> | if (setgid(e->gid) !=3D 0)
> | _exit(ERROR_EXIT);
--=20
That must be wonderful! I don't understand it at all.
-- Moliere
--GcSOTaE82DYSpZPK
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (FreeBSD)
iD8DBQFEjH3IocfcwTS3JF8RAjPTAJ9J99JffLEOiH1HlmGAv9vjNVn3MgCfYCQs
4PWepwS4zR89ZOxpeS1qnLY=
=4wEU
-----END PGP SIGNATURE-----
--GcSOTaE82DYSpZPK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060611203208.GL23618>