From owner-svn-src-head@FreeBSD.ORG Thu Apr 25 06:45:27 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9ACBB76F; Thu, 25 Apr 2013 06:45:27 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 1176811D2; Thu, 25 Apr 2013 06:45:25 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id JAA11867; Thu, 25 Apr 2013 09:45:17 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1UVFvg-0000QO-Il; Thu, 25 Apr 2013 09:45:16 +0300 Message-ID: <5178D0F9.9000801@FreeBSD.org> Date: Thu, 25 Apr 2013 09:45:13 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130405 Thunderbird/17.0.5 MIME-Version: 1.0 To: Mark Johnston Subject: Re: svn commit: r248644 - head/cddl/contrib/opensolaris/lib/libdtrace/common References: <201303230857.r2N8vsHL058716@svn.freebsd.org> <20130421030818.GA23819@gloom> In-Reply-To: <20130421030818.GA23819@gloom> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2013 06:45:27 -0000 on 21/04/2013 06:08 Mark Johnston said the following: > On Sat, Mar 23, 2013 at 08:57:54AM +0000, Andriy Gapon wrote: >> Author: avg >> Date: Sat Mar 23 08:57:54 2013 >> New Revision: 248644 >> URL: http://svnweb.freebsd.org/changeset/base/248644 >> >> Log: >> dtrace: ensure that we can always catch a process (e.g. when -c is used) >> >> It is not guaranteed that a program has a symbol table entry for main >> and thus that it would be possible to set a breakpoint on it. >> >> Reviewed by: rpaulo >> Discussed with: rpaulo >> MFC after: 13 days > > Hi Andriy, > > This commit seems to break USDT for me. When I for instance try to run > the toy example at https://wiki.freebsd.org/DTrace/userland (the > database provider), I get > > markj@gloom: ~/tmp/dtrace/db $ sudo dtrace -s db.d -c ./db > dtrace: failed to compile script db.d: line 2: probe description database23147:::query-start does not match any probes > > When I revert this commit and recompile the example program and > libdtrace, it works as expected. Mark, thank you very much for the report. It seems that I didn't fully understand consequences of the change when I made it. I am still looking into the details of the relevant differences between Solaris/Illumos and FreeBSD. Because I am going on a vacation I've decided to revert this commit for now. -- Andriy Gapon