From nobody Mon Sep 18 13:26:56 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rq5FX6TtMz4tCDV; Mon, 18 Sep 2023 13:27:44 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rq5FX3jbHz4TCK; Mon, 18 Sep 2023 13:27:44 +0000 (UTC) (envelope-from mavbsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-59eb8ec5e20so5335107b3.3; Mon, 18 Sep 2023 06:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695043664; x=1695648464; darn=freebsd.org; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :from:to:cc:subject:date:message-id:reply-to; bh=1Z7l643Yn4U0JvUDehwbKGT0tZjuvthQNYn4W2LON3w=; b=UYcxlvq/wjLbPe7DQAKfizx6qAM6wZX0NbRpvWTxpOzyWZFRxFVlCVIT3I0xnvAAA5 bg/o6RHi/xWzIkILmJ8zllYNBNNfn4lVTm6/Pc9KxZHKS2t7KdtGCMOF+ub/tIuOHOrV NmCSvk32jdFyNxTBYvx5cuNoG57+dXFdJzNaoi8d2exFZy0TKfwCRLQE3Gr0CcZ9ovb8 jQeP2D/irCWhaS9kUJZenYDrmTAIaVjxU3WzdhwbuMCGI0pmOrx4spJckf9T5xiqQjL/ 4l5cU91yOsX7ZyrciDVCeQgWVEhsCyRyyXK2UwoTAthQN6XJNap+XhxkoEatvtmNT1/u 9pfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695043664; x=1695648464; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1Z7l643Yn4U0JvUDehwbKGT0tZjuvthQNYn4W2LON3w=; b=O1dCashp3wB7FE0mQghEAkdeBFquLEaZh1j/YyS40tK56EKTjDBHuQTWjvdj4+Kh0U XE21WU6GHc2NreAfqBw/R03VXFoclxwN3cZBZ6i5ZRJ/Xov1g7aAoHaorDOZIjQq+dtF cfpbr86EpFmocvqe42L8/Hwyxy2HLZ74WDZubDSnWHCJNAwh0vKGkSfFg7wVFzxruVYZ si+BZiA67XAIk13x92eoL9mXLpXwrAGWCBn2UCNdgfMlLAtAnd7xTBGCYezBueagoWja jlggugJfEu0GJwpyvnQWznXoeWAQjulYw4N0aWgd54JE1HpIC4bV7LgYc+9hpQeWg8Y7 44jQ== X-Gm-Message-State: AOJu0Yy/bxUMW68cS7PAKmwRwtRX81EuAQPybfIWcR0YsmjXWBUL3p8H Kzob8FxIZFnhA9Fg06elqgh/UNtdeGp7Mg== X-Google-Smtp-Source: AGHT+IGaBdroTsb4rijFVSTO10FO7CAbwubxKiPmKoV5uhcoNVpQb1NgwJNqOrKJV1eiWuLUbpSl4Q== X-Received: by 2002:a0d:f103:0:b0:59b:4ed2:a33 with SMTP id a3-20020a0df103000000b0059b4ed20a33mr8311350ywf.35.1695043663713; Mon, 18 Sep 2023 06:27:43 -0700 (PDT) Received: from [10.230.45.5] ([38.32.73.2]) by smtp.gmail.com with ESMTPSA id er4-20020a05690c2d8400b0057a0e5b18e0sm546832ywb.142.2023.09.18.06.27.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 06:27:43 -0700 (PDT) Message-ID: Date: Mon, 18 Sep 2023 09:26:56 -0400 List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Tomoaki AOKI , Martin Matuska Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org References: <20230916002831.GU52318@FreeBSD.org> <02c53c2e-127b-33b4-e13d-f6f6589dd5fe@gmail.com> <7a6692de-f096-637d-fe48-d5fb93e54f8b@FreeBSD.org> <8e4e4000-4680-0550-6772-32a6a3101761@FreeBSD.org> <20230918202204.28e21a011a0a98e3fcda9f3a@dec.sakura.ne.jp> From: Alexander Motin Subject: Re: vfs.zfs.bclone_enabled (was: FreeBSD 14.0-BETA2 Now Available) In-Reply-To: <20230918202204.28e21a011a0a98e3fcda9f3a@dec.sakura.ne.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Rq5FX3jbHz4TCK block_cloning feature is marked as READONLY_COMPAT. It should not require any special handling from the boot code. On 18.09.2023 07:22, Tomoaki AOKI wrote: > Really OK? > > I cannot find block_cloning in array *features_for_read[] of > stand/libsa/zfs/zfsimpl.c, which possibly mean boot codes (including > loader) cannot boot from Root-on-ZFS pool having block_cloning active. > > Not sure adding '"com.fudosecurity:block_cloning",' here is sufficient > or not. Possibly more works are needed. > > IMHO, all default-enabled features should be safe for booting. > Implement features with disalded, impement boot codes to support them, > then finally enable them by default should be the only valid route. > > > [1] https://cgit.freebsd.org/src/tree/stand/libsa/zfs/zfsimpl.c > > > On Mon, 18 Sep 2023 07:31:46 +0200 > Martin Matuska wrote: > >> I vote for enabling block cloning on main :-) >> >> mm >> >> On 16. 9. 2023 19:14, Alexander Motin wrote: >>> On 16.09.2023 01:25, Graham Perrin wrote: >>>> On 16/09/2023 01:28, Glen Barber wrote: >>>>> o A fix for the ZFS block_cloning feature has been implemented. >>>> >>>> Thanks >>>> >>>> I see >>>> , >>>> with >>>> >>>> in stable/14. >>>> >>>> As vfs.zfs.bclone_enabled is still 0 (at least, with 15.0-CURRENT >>>> n265350-72d97e1dd9cc): should we assume that additional fixes, not >>>> necessarily in time for 14.0-RELEASE, will be required before >>>> vfs.zfs.bclone_enabled can default to 1? >>> >>> I am not aware of any block cloning issues now.  All this thread about >>> bclone_enabled actually started after I asked why it is still >>> disabled. Thanks to Mark Millard for spotting this issue I could fix, >>> but now we are back at the point of re-enabling it again.  Since the >>> tunable does not even exist anywhere outside of FreeBSD base tree, I'd >>> propose to give this code another try here too.  I see no point to >>> have it disabled at least in main unless somebody needs time to run >>> some specific tests first. > -- Alexander Motin