From owner-cvs-all@FreeBSD.ORG  Sat Jul 14 08:12:27 2012
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 619C11065674; Sat, 14 Jul 2012 08:12:27 +0000 (UTC)
Date: Sat, 14 Jul 2012 08:12:27 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Matthew Seaman <matthew@FreeBSD.org>
Message-ID: <20120714081227.GA66156@FreeBSD.org>
References: <201207131023.q6DANo8l081040@repoman.freebsd.org>
	<20120714070300.GA55269@FreeBSD.org> <500120A8.700@yandex.ru>
	<20120714075126.GA62010@FreeBSD.org> <50012859.1080906@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <50012859.1080906@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
Cc: Koop Mast <kwm@FreeBSD.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org,
	Ruslan Mahmatkhanov <cvs-src@yandex.ru>, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/games/gcompris Makefile distinfo pkg-descr
	pkg-plist
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jul 2012 08:12:27 -0000

On Sat, Jul 14, 2012 at 09:05:45AM +0100, Matthew Seaman wrote:
> On 14/07/2012 08:51, Alexey Dokuchaev wrote:
> > On Sat, Jul 14, 2012 at 11:32:56AM +0400, Ruslan Mahmatkhanov wrote:
> >> I always replace this space with a tab (in a manner as vars and values
> >> are separated in Makefile). Does it documented somewhere? And what the
> >> reason may be of space is preferable? Thanks.
> > 
> > Well, pkg-descr is not a Makefile.  In makefiles, tabs help to align the
> > values nicely, as it helps readability a lot.  On the contrary, pkg-descr
> > is mostly simple text, so there is not need to abuse tab here where single
> > space perfectly suffices and IMHO looks a lot better.
> > 
> > Sadly, as with other stylish rather than functional issues, it does not
> > seem to be documented.  Hopefully after switch to SVN it would be easier
> > to isolate this kind of mechanical commits, and I will ask permission to
> > convert every port to single space + submit a patch to someone on doc@
> > team to be added to PH.
> 
> Actually, it would make a lot of sense to take the WWW entries out of
> pkg-descr files entirely, and have them a variable in the main port
> Makefile instead.
> 
> This would, at a stroke, reduce the number of files that need to be read
> to generate the INDEX by a factor of around 2, and consequentially speed
> things up.

Yes, this is also a good idea.  pkg-descr can be generated automagically in
this case for installed ports/packages.

./danfe