From owner-svn-src-head@freebsd.org Thu Jul 9 04:08:20 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4519035F53C; Thu, 9 Jul 2020 04:08:20 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B2N2C4DMZz4TvS; Thu, 9 Jul 2020 04:08:19 +0000 (UTC) (envelope-from yuripv@yuripv.dev) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id A59085800B0; Thu, 9 Jul 2020 00:08:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 09 Jul 2020 00:08:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.dev; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=o S318L/pcAaZLnwGE0w6/DX5AzX0qKmUuAgCZ+Ho59Q=; b=bam2+s2HiyLYUGLHj Z05kYrTNaxuskaNLVTZwmqRJgGxu6t3Wkis6cieODn7UsnDO69rcGhAOVb3wu0xE fG6P8v9m5dZgRxNUbzmE9OHhWnQqfpJmrtSZ3QmCQhugtCa3P8+EVDM9mdVtjYG5 sHe7UjxnQ+eW4cYw2jpkOwybJzjMdxH27EiipVJCQAoCjkBb2CzpLUhJMgchbM3n awUIMEWqW/+eiot69BaYzkaPhhIN6vAG2q+IN9S/D6Zvnux4Z5yudA3OsVDBmSGU PMJ/SO1bc0+HgXNpwWujK/JJ92lQWWodxD3q1B++/e4hTglk0i9VTS9L98u0GrZa gQ/aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=oS318L/pcAaZLnwGE0w6/DX5AzX0qKmUuAgCZ+Ho5 9Q=; b=HKke1khTqrBkg7aNEOp/zm/cR/itEJx4RqBZ5dFHek8ZsWPJFqJk88nn7 YPWqrPiL5rsWSs10CPY3BzDozMnbuxhzHYiit4NKYYbWpMRMfHTF81GxowaLy4+S /xcYe44zrWq34YnIXViWrl+n4/zXWVQfBJeBS9tXF8bkvokV+hXXXs0h07uuBvXI +J6l87VMYxvByNoPMhFuSxq4bJtqRT/HaVLpLDl0JeGNcST6n0tgVidK0wWsskRb xUzZQoX/ZexL/gV5DXnNLjuAf8Zz38GpzUf8K8QFCzp2KW39XdrsiI1weaZNfeSs AfDPgRJlNcY6SoWJVNpPTJtbABUXw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudekgdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpegjuhhrihcu rfgrnhhkohhvuceohihurhhiphhvseihuhhrihhpvhdruggvvheqnecuggftrfgrthhtvg hrnhephfelveehgfeujeefhfeluddtiedttdeuffdvfeehjeeitddvudefkeehgfejiedu necuffhomhgrihhnpegtohhmphhilhgvrhdrmhhkpdhshihsrdhmkhdpphhorhhtrdhmkh enucfkphepledurddvgedtrdduvdegrddufeejnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhephihurhhiphhvseihuhhrihhpvhdruggvvh X-ME-Proxy: Received: from [192.168.1.6] (unknown [91.240.124.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 609A7328005A; Thu, 9 Jul 2020 00:08:17 -0400 (EDT) Subject: Re: svn commit: r363031 - in head: contrib/bmake contrib/bmake/lst.lib contrib/bmake/mk contrib/bmake/mk/sys contrib/bmake/unit-tests usr.bin/bmake (make now broken) To: Mark Millard Cc: "sjg@freebsd.org" , svn-src-head@freebsd.org, FreeBSD Toolchain , FreeBSD Current References: <25afe2ff-e805-8415-ddd9-430cfa271e16@yuripv.dev> <8969386C-D964-4597-BE7E-6A2D215D801C@yahoo.com> From: Yuri Pankov Message-ID: Date: Thu, 9 Jul 2020 07:08:15 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8969386C-D964-4597-BE7E-6A2D215D801C@yahoo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4B2N2C4DMZz4TvS X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yuripv.dev header.s=fm1 header.b=bam2+s2H; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=HKke1khT; dmarc=none; spf=pass (mx1.freebsd.org: domain of yuripv@yuripv.dev designates 66.111.4.229 as permitted sender) smtp.mailfrom=yuripv@yuripv.dev X-Spamd-Result: default: False [1.66 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:66.111.4.229:c]; URIBL_RED(3.50)[yuripv.dev:dkim]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[yuripv.dev:+,messagingengine.com:+]; HAS_ANON_DOMAIN(0.10)[]; NEURAL_HAM_SHORT(-0.05)[-0.051]; FREEMAIL_TO(0.00)[yahoo.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[66.111.4.229:from]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.89)[-0.890]; R_DKIM_ALLOW(0.00)[yuripv.dev:s=fm1,messagingengine.com:s=fm3]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.90)[-0.897]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[yuripv.dev]; BAD_REP_POLICIES(0.10)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RWL_MAILSPIKE_VERYGOOD(0.00)[66.111.4.229:from] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2020 04:08:20 -0000 Mark Millard wrote: > > > On 2020-Jul-8, at 20:35, Yuri Pankov wrote: > >> Mark Millard wrote: >>> This seems to have broken doing buildworld buildkernel and >>> other things using make: >>> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String comparison operator should be either == or != >>> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String comparison operator should be either == or != >>> . . . >>> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 100: warning: String comparison operator should be either == or != >>> . . . >>> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 81: warning: String comparison operator should be either == or != >>> . . . >>> Using -d c shows the likes of: >>> . . . >>> lhs = "clang", rhs = "clang", op = == >>> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs = "gcc", op = == >>> make[2]: "/usr/src/share/mk/bsd.compiler.mk" line 197: warning: String comparison operator should be either == or != >>> lhs = "clang", rhs = "clang", op = == >>> lhs = "LD", rhs = "LD", op = == >>> . . . >>> left = 6.000000, right = 2.000000, op = <= >>> left = 6.000000, right = 1.000000, op = <= >>> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs = "clang", op = == >>> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 100: warning: String comparison operator should be either == or != >>> lhs = "${${:UCOMPILER_TYPE}__${${:U${_empty_var_}}_cc_hash}}", rhs = "gcc", op = == >>> lhs = "clang", rhs = "gcc", op = == >>> . . . >>> left = 0.000000, right = 6.000000, op = <= >>> left = 0.000000, right = 3.000000, op = <= >>> lhs = "clang", rhs = "gcc", op = == >>> make[3]: "/usr/src/share/mk/bsd.sys.mk" line 81: warning: String comparison operator should be either == or != >>> lhs = "clang", rhs = "clang", op = == >>> left = 100001.000000, right = 70000.000000, op = >= >>> lhs = "amd64", rhs = "arm", op = == >>> (Now I just need to figure out how to get back to a working context.) >> >> For me, buildworld/buildkernel produced only warnings, > > But, looking at the code in bmake, the expression is also > evaluated differently/incorrectly when it is classified as > having the problem of having a incorrect operator. In other > words: the behavior in make changes via misevaluated > expressions. > > >> though the one in ports is real issue: >> >> $ make config >> make: "/usr/ports/Mk/bsd.port.mk" line 2096: warning: String comparison operator should be either == or != >> make: "/usr/ports/Mk/bsd.port.mk" line 2096: Malformed conditional (defined(MAKE_JOBS_NUMBER_LIMIT) && ( ${MAKE_JOBS_NUMBER_LIMIT} < ${_MAKE_JOBS_NUMBER} )) >> make: Fatal errors encountered -- cannot continue >> make: stopped in /usr/ports/devel/subversion > > Not the only "real issue", I'm afraid. Yeah, sorry, looks like I'm late to the party, and it was already discussed and reverted.