From owner-freebsd-net@FreeBSD.ORG  Sat Aug 16 19:20:57 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E3823E78;
 Sat, 16 Aug 2014 19:20:57 +0000 (UTC)
Received: from forward-corp1e.mail.yandex.net (forward-corp1e.mail.yandex.net
 [IPv6:2a02:6b8:0:202::10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "forwards.mail.yandex.net",
 Issuer "Certum Level IV CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 8E07E2D3A;
 Sat, 16 Aug 2014 19:20:57 +0000 (UTC)
Received: from smtpcorp4.mail.yandex.net (smtpcorp4.mail.yandex.net
 [95.108.252.2])
 by forward-corp1e.mail.yandex.net (Yandex) with ESMTP id A87886404E5;
 Sat, 16 Aug 2014 23:20:53 +0400 (MSK)
Received: from smtpcorp4.mail.yandex.net (localhost [127.0.0.1])
 by smtpcorp4.mail.yandex.net (Yandex) with ESMTP id 5EB112C0535;
 Sat, 16 Aug 2014 23:20:53 +0400 (MSK)
Received: from unknown (unknown [2a02:6b8:0:401:222:4dff:fe50:cd2f])
 by smtpcorp4.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id
 VG8XbtLtep-KrIWwTTI; Sat, 16 Aug 2014 23:20:53 +0400
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (Client certificate not present)
X-Yandex-Uniq: 3f4a58df-5fdb-4710-8b56-59ffc8d03cfe
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;
 s=default; 
 t=1408216853; bh=RG+JAc5gu5mEGkQ+R4hFCLhCsWQfy5cZanfSPvAvqPI=;
 h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:
 Content-Type;
 b=kbL7l1RYWj76yjU6WtMCdysoJxQMFP6SN7lYFHGHUd6rLsM356mcpQHwqY6x8t/m2
 2Snjd5ZZKIuPa5gyUvcPNBbt80EqVri48wbSr/GP/YdEJb6eg6eKphcO+c8kQ50JoM
 UVouQKwGDgNT/uTewDo9D9jnId9iyI6wBXahvaO4=
Authentication-Results: smtpcorp4.mail.yandex.net;
 dkim=pass header.i=@yandex-team.ru
Message-ID: <53EFAF0B.6060301@yandex-team.ru>
Date: Sat, 16 Aug 2014 23:20:43 +0400
From: "Alexander V. Chernikov" <melifaro@yandex-team.ru>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: jfv@FreeBSD.org
Subject: ixgbe i2c interface
Content-Type: multipart/mixed; boundary="------------040509000500010406020307"
Cc: FreeBSD Net <net@freebsd.org>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Aug 2014 19:20:58 -0000

This is a multi-part message in MIME format.
--------------040509000500010406020307
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hello Jack!

Can you please commit (or let me commit) the following one-liner?

--------------040509000500010406020307
Content-Type: text/x-patch;
 name="ixgbe_i2c.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="ixgbe_i2c.diff"

Index: sys/dev/ixgbe/ixgbe.c
===================================================================
--- sys/dev/ixgbe/ixgbe.c	(revision 270040)
+++ sys/dev/ixgbe/ixgbe.c	(working copy)
@@ -1055,7 +1055,7 @@ ixgbe_ioctl(struct ifnet * ifp, u_long command, ca
 		error = copyin(ifr->ifr_data, &i2c, sizeof(i2c));
 		if (error)
 			break;
-		if ((i2c.dev_addr != 0xA0) || (i2c.dev_addr != 0xA2)){
+		if ((i2c.dev_addr != 0xA0) && (i2c.dev_addr != 0xA2)){
 			error = EINVAL;
 			break;
 		}

--------------040509000500010406020307--