From owner-freebsd-bugs@FreeBSD.ORG  Sat Aug 16 21:00:19 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E8AB337B401
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 16 Aug 2003 21:00:19 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7D9F043F93
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 16 Aug 2003 21:00:19 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h7H40JUp075706
	for <freebsd-bugs@freefall.freebsd.org>;
	Sat, 16 Aug 2003 21:00:19 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h7H40JP4075705;
	Sat, 16 Aug 2003 21:00:19 -0700 (PDT)
Date: Sat, 16 Aug 2003 21:00:19 -0700 (PDT)
Message-Id: <200308170400.h7H40JP4075705@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Eugene Grosbein <eugen@kuzbass.ru>
Subject: Re: bin/55346: /bin/sh eats memory and CPU infinitely
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Eugene Grosbein <eugen@kuzbass.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Aug 2003 04:00:20 -0000

The following reply was made to PR bin/55346; it has been noted by GNATS.

From: Eugene Grosbein <eugen@kuzbass.ru>
To: Doug White <dwhite@gumbysoft.com>
Cc: stable@freebsd.org, bug-followup@freebsd.org
Subject: Re: bin/55346: /bin/sh eats memory and CPU infinitely
Date: Sun, 17 Aug 2003 11:50:54 +0800

 Doug White wrote:
 
 > Ah, OK, I follow you there. send-pr away.
 
 It seems that patch replaces memory leak with double-free bug:
 waitforjob() will call freejob() just after dowait().
 
 This corrected version removes extra freejob() call.
 
 --- jobs.c.orig Mon Aug  4 11:48:00 2003
 +++ jobs.c      Sun Aug 17 11:20:55 2003
 @@ -889,8 +889,6 @@
  #endif
         else
                 st = WTERMSIG(status) + 128;
 -       if (! JOBS || jp->state == JOBDONE)
 -               freejob(jp);
         if (int_pending()) {
                 if (WIFSIGNALED(status) && WTERMSIG(status) == SIGINT)
                         kill(getpid(), SIGINT);
 @@ -960,10 +958,8 @@
                                 if (jp->state != state) {
                                         TRACE(("Job %d: changing state from %d
 to %d\n", jp -
 jobtab + 1, jp->state, state));
                                         jp->state = state;
 -#if JOBS
                                         if (done)
 -                                               deljob(jp);
 -#endif
 +                                               freejob(jp);
                                 }
                         }
                 }
 
 
 Eugene Grosbein