From owner-freebsd-current@FreeBSD.ORG Thu Apr 30 17:13:42 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3DE36106566C for ; Thu, 30 Apr 2009 17:13:42 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.247]) by mx1.freebsd.org (Postfix) with ESMTP id E20CE8FC12 for ; Thu, 30 Apr 2009 17:13:41 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by an-out-0708.google.com with SMTP id c3so1156385ana.13 for ; Thu, 30 Apr 2009 10:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=ax3MWTgJYH+kRvhzBP97IixuluP5auqCfBcVi7+VJu0=; b=tSJpmyUhgWg+VcvFE/mE9YqfJCxAfu5Uet4KF+iaG5pGrdecvr/KfLKt0Hj+hRBy0O g3gnbtmv4UBIxI02IgwECWUskdYk7THrbcUrhE8cEzagBQ/NlobOwJpMGk7SlGDipZgE YU7/azgmdt3Qpl2kTpFprGkO1Qc5jTZEBwZyY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=ioi68qicqLSaZJV4m9zNc04xgHH2/Yf40hGUZZp2jAVNJRiE0Wg5zGo1D4BH/h/HZt fPLpSW3j5SHvRQneLmjVJ2E1mMjZUFEPwvMRygGGJXfysrjfG7HlxzL5Hn22STv/HWMh ZcdO7lFUkiGae49DMaXvfSQpQn/bv79r6oof8= MIME-Version: 1.0 Sender: mat.macy@gmail.com Received: by 10.100.44.4 with SMTP id r4mr3514693anr.157.1241111621026; Thu, 30 Apr 2009 10:13:41 -0700 (PDT) In-Reply-To: References: <4D8E4457-89AA-4F19-9960-E090D3B8E319@wanderview.com> <20090429064303.GA2189@a91-153-125-115.elisa-laajakaista.fi> <49F8E71B.2020102@freebsd.org> <38E0E938-68DA-4D2E-8191-3CEC836A82E9@wanderview.com> <3c1674c90904300019w63f31ac0n141c3d5116eadb97@mail.gmail.com> Date: Thu, 30 Apr 2009 10:13:40 -0700 X-Google-Sender-Auth: 55efeb1f4443d4d2 Message-ID: <3c1674c90904301013k1ca3b0d9x4f3389591db99a0b@mail.gmail.com> From: Kip Macy To: Ben Kelly Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: current@freebsd.org Subject: Re: [patch] zfs livelock and thread priorities X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2009 17:13:42 -0000 On Thu, Apr 30, 2009 at 8:55 AM, Ben Kelly wrote: > On Apr 30, 2009, at 3:19 AM, Kip Macy wrote: >> >> I have a system at work that I could lock up within minutes with >> fsstress. With this patch the system is now stable with large numbers >> of fsstress processes running. >> >> Provided I get the heads up from pjd, I will commit it. > > I found on my system that I could not zfs export my pool after running my > load test with this patch. =A0To try to fix this I've updated the patch t= o > delegate to vrele(9) instead of directly decrementing the vnode count. = =A0I > also modified the deferred operation to restart a full vrele(9) instead o= f > calling VOP_INACTIVE since it occurred to me someone else might have grab= bed > the vnode while our task was on the queue. =A0I have only had time to run= a > short test, but it seems to avoid the problem so far. > > Can you retest with these changes? >\ I'll try deferring the entire vrele. -Kip