From owner-svn-src-all@freebsd.org Wed May 29 11:54:17 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90DF615C06F0; Wed, 29 May 2019 11:54:17 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2607:f740:d:20::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2139B8F849; Wed, 29 May 2019 11:54:17 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 45DTdf3x4fz3c7W; Wed, 29 May 2019 11:54:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([127.0.0.1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [127.0.0.1]) (amavisd-new, port 10587) with ESMTPS id v8lPjebk7D07; Wed, 29 May 2019 11:54:14 +0000 (UTC) Received: from garnet.daemonic.se (host-95-192-108-109.mobileonline.telia.com [95.192.108.109]) by mail.daemonic.se (Postfix) with ESMTPSA id 45DTdd5mqxz3c7V; Wed, 29 May 2019 11:54:13 +0000 (UTC) Subject: Re: svn commit: r348355 - head/sys/dev/iicbus To: Andriy Gapon , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201905290908.x4T98L89066643@repo.freebsd.org> From: Niclas Zeising Message-ID: Date: Wed, 29 May 2019 13:54:06 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <201905290908.x4T98L89066643@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2139B8F849 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 May 2019 11:54:17 -0000 On 2019-05-29 11:08, Andriy Gapon wrote: > Author: avg > Date: Wed May 29 09:08:20 2019 > New Revision: 348355 > URL: https://svnweb.freebsd.org/changeset/base/348355 > > Log: > revert r273728 and parts of r306589, iicbus no-stop by default feature > > Since drm2 removal, there has not been any consumer of the feature in the > tree. I am also unaware of any out-of-tree consumer. > More importantly, the feature has been broken from the very start, both > before and after r306589, because the ivar was set on a device that does > not support it and it was read from another device that also does not > support it. > > A bus-wide no-stop flag cannot be implemented as an ivar as iicbus > attaches as a child of various drivers. Implementing the ivar in each > and every I2C driver is just impractical. > > If we ever want to implement this feature properly, then probably the > easiest way to do it would be via a flag in the softc of iicbus. > In fact, we might have to do that in the stable branches if we want to > fix the code for them. > > Reported by: ian (long time ago) > MFC after: 1 month (maybe) > X-MFC-note: cannot just merge the change, must keep drm2 happy > Hi! Just a note, be aware that drm2 lives on in ports as drm-legacy-kmod. I haven't tested, but, from the description above I worry that it will affect the port. What do you think? Regards -- Niclas