From owner-freebsd-ports@freebsd.org Mon Mar 21 20:43:51 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AFE29AD8433 for ; Mon, 21 Mar 2016 20:43:51 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A0D0AC81 for ; Mon, 21 Mar 2016 20:43:51 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 9C55AAD8432; Mon, 21 Mar 2016 20:43:51 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9BF47AD8431 for ; Mon, 21 Mar 2016 20:43:51 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7AC07C7F; Mon, 21 Mar 2016 20:43:51 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u2LKhhuU061228; Mon, 21 Mar 2016 13:43:47 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <201603212043.u2LKhhuU061228@gw.catspoiler.org> Date: Mon, 21 Mar 2016 13:43:43 -0700 (PDT) From: Don Lewis Subject: Re: gnome-post-install ordering To: mat@FreeBSD.org cc: ports@FreeBSD.org In-Reply-To: MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 20:43:51 -0000 On 21 Mar, Mathieu Arnold wrote: > +--On 21 mars 2016 11:18:26 -0700 Don Lewis wrote: > | gnome-post-install does several different things. I haven't looked to > | see if all of them should be moved. Unfortunately I'm not sure that an > | exp-run would pick up some of the more subtle breakage. > > Then, we just extract the INSTALL_ICONS bits into a gnome-install-icons > target, and run it later, much later. The gnome-post-install target could > benefit from being split up. It was not so before because USES=gnome is > quite new, and adding stuff to the target ordering system was a pain. Now, > it could be splitted in gnome-gconf-schemas, gnome-glib-schemas, > gnome-installs-omf, and gnome-install-icons. It was on my roadmap when I > rewrote the target ordering system to use numbers, but I decided against > changing too many things at once. That sounds fine to me. I didn't closely look at the rest of gnome-post-install since I was concentrating on the problem at hand. I'd also like a target explicity for generating a dynamic plist that runs after post-install. Doing it in post-install works most of the time unless you start using post-install option helpers to install additional files. > | One of my concerns is that if we start using TARGET_ORDER_OVERRIDE all > | over the place, that will make maintaining the framework a lot more > | difficult. > > There's a difference between all over the place and in a dozen ports :-) > (it only makes it about 0.05% of the time, if I get my math right) Well, here are a bunch more ... these contain both INSTALLS_ICONS and "autoplist", which I'm assuming comes from USES_GNOME=autoplist audio/puddletag/Makefile deskutils/gtg/Makefile deskutils/rednotebook/Makefile deskutils/syncthing-gtk/Makefile deskutils/vboxgtk/Makefile deskutils/virt-manager/Makefile deskutils/zim/Makefile devel/bzr-gtk/Makefile devel/gaphor/Makefile devel/qbzr/Makefile games/pyspacewar/Makefile multimedia/tovid/Makefile net-im/turpial/Makefile net-p2p/deluge/Makefile print/frescobaldi/Makefile www/linkchecker/Makefile x11/hotwire-shell/Makefile