From owner-freebsd-arch@FreeBSD.ORG Fri Mar 20 21:14:44 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D0CF9EB9 for ; Fri, 20 Mar 2015 21:14:44 +0000 (UTC) Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 97204CF7 for ; Fri, 20 Mar 2015 21:14:44 +0000 (UTC) Received: by pdbcz9 with SMTP id cz9so119270630pdb.3 for ; Fri, 20 Mar 2015 14:14:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=w3v36h3qbr8DGU8VmnflaMoSGL1MPBFlhwvdXGduBno=; b=mX9nRzbXpy8LPT0FUWc6Wzqd6iRTVzihUfGIHY9uSb+lvzLjzpOz8xNR7VToix77o3 clpqV7HWEDKXy99l89mwhRFuiVeMYPUk6EXG3v1QxCdz7pBNu1JDHDJoMNjG5Tx72ejW tOifvF3cqRm8tKOx1MseXRijN7gRaAjzXZP3Ita6n/Bzm+Fgs2926j6pzGnNiXy6q4RB V2ARbNzKGDRutGnuzouCmoifhFaGWgM0x8Vk/SuuK3ISPRagafEeAp4ZLlzzdBAUF0rK gsRwBLLsX3PhXXokC+P8+6WSxkF/SfQRiYkSMq1xcyW3s5/jWG5RFjfWQVI5RijG8sQ0 +EGA== X-Gm-Message-State: ALoCoQm6tPs2s6q8gb1E9+1pvXdmAxvwNT3lI+HRX6vCLf/r1ZrxzoW82A8WZPI2KeXZhuyElc2h X-Received: by 10.70.132.36 with SMTP id or4mr121880113pdb.59.1426886078507; Fri, 20 Mar 2015 14:14:38 -0700 (PDT) Received: from [10.64.25.47] ([69.53.236.236]) by mx.google.com with ESMTPSA id qo4sm9658771pab.33.2015.03.20.14.14.36 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Mar 2015 14:14:37 -0700 (PDT) Sender: Warner Losh Subject: Re: ASLR work into -HEAD ? Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_D7C94696-EF5C-4348-9F24-E05CC351FC5C"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: <1426878339.5550.29.camel@hardenedbsd.org> Date: Fri, 20 Mar 2015 15:14:30 -0600 Message-Id: References: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> <1426875464.5550.26.camel@hardenedbsd.org> <1426878339.5550.29.camel@hardenedbsd.org> To: Shawn Webb X-Mailer: Apple Mail (2.2070.6) Cc: Adrian Chadd , HardenedBSD Core , Oliver Pinter , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 21:14:45 -0000 --Apple-Mail=_D7C94696-EF5C-4348-9F24-E05CC351FC5C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 20, 2015, at 1:05 PM, Shawn Webb = wrote: >=20 > On Fri, 2015-03-20 at 14:17 -0400, Shawn Webb wrote: >> On Fri, 2015-03-20 at 09:28 -0600, Warner Losh wrote: >>>> On Mar 19, 2015, at 2:31 PM, Oliver Pinter = wrote: >>>>=20 >>>> On Thu, Mar 19, 2015 at 9:04 PM, Adrian Chadd = wrote: >>>>> On 19 March 2015 at 12:56, Warner Losh wrote: >>>>>>=20 >>>>>>> On Mar 19, 2015, at 12:53 PM, Adrian Chadd = wrote: >>>>>>>=20 >>>>>>> Hi, >>>>>>>=20 >>>>>>> Apparently this is done but has stalled: >>>>>>>=20 >>>>>>> https://reviews.freebsd.org/D473 >>>>>>>=20 >>>>>>> Does anyone have any strong objections to it landing in the tree = as-is? >>>>>>=20 >>>>>> There=E2=80=99s rather a lot of them specifically spelled out in = the code review. >>>>>>=20 >>>>>> Many of the earlier ones were kinda blown off, so I=E2=80=99ve = not been inclined >>>>>> to take the time to re-review it. Glancing at it, I see several = minor issues >>>>>> that should be cleaned up. >>>>>=20 >>>>> Cool. Thanks for taking the time to look at it again. >>>>>=20 >>>>> Shawn is in #freebsd on freenode irc, so if you/others want a more >>>>> interactive review then he's there during the day. >>>>=20 >>>> Please CC the core@hardenedbsd.org in future please, when you are >>>> talking about this issue. >>>>=20 >>>> Adrian: do you able to review the MIPS or ARM part especially or = test them? >>>=20 >>> Adrian: Do not commit the changes. >>>=20 >>> I=E2=80=99ve gone back and re-read Robert Watson=E2=80=99s rather = long review and it appears >>> that virtually none of that has been addressed. Until it is, do not = commit it. This >>> code interacts with dangerous parts of the system, and the default = cannot be >>> to just let it in because no one has objected recently. Objections = have been made, >>> they have been quantified, they haven=E2=80=99t been answered or = acted upon. Until that >>> changes, you can assume the objections remain in place and asking = again without >>> fixing them isn=E2=80=99t going to change the answer. >>>=20 >>> Warner >>=20 >> Warner, >>=20 >> We've fixed the vast majority of the concerns raised in that review. = To >> say "virtually none of that has been addressed" and "they haven't = been >> answered or acted upon" is a blatant lie. The fact that there are so >> many revisions of the patch is proof. We even made our ASLR >> implementation for FreeBSD less secure by providing a mechanism in >> ptrace() to disable it as requested by a member of the FreeBSD >> Foundation. (This "feature" doesn't exist in HardenedBSD's >> implementation.) If comments like these continue, I will remove the = diff >> from Phabricator and close the BugZilla ticket. FreeBSD can feel free = to >> pull from us, but we won't make any effort to proactively upstream = our >> work. >>=20 >> With that said, I have missed a few of the concerns raised. There's = so >> many comments/concerns in that review that it's easy to miss a few. I >> will address them tonight and upload a new patch tomorrow. >=20 > I've updated the patch. Is there anything I've missed? I=E2=80=99ve taken a look at the updated patch and see that it addressed = the issues I raised. It almost looks like the update to the review a month ago was the wrong version, since so many more of the original comments appear to be addressed than when I looked. Thanks! Warner --Apple-Mail=_D7C94696-EF5C-4348-9F24-E05CC351FC5C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVDI22AAoJEGwc0Sh9sBEAu+8QALGiZEBaYbyODq+zgT93HuIS CU7/NCaiVOVk2A6GqLEUgrxqFfGT306BqlJK4omsShzpSzadGs73yv2xJjqxZAVH MOlUUcJ/xvK1NZIvOU5K7r8ey9rtdk59X7R1zBzjGpi2TN6GDVhZ9MzvCciJsAUe OGkFni6Oe3bYhOVFRDX7Y0Q6gVF+m8ZkDqMbSi4QqoIQOGdia7Ijc1+6G0ZLSa1f VE7mcG0iXgFdi/xB7RDYE4xOzegDKzbxWqfBVGX5qWxm5Q3vbIpMFVoEXNAO7umK i23Z3f+EdnrunLcK7d51XdMccuXwI3nMIpdgs0DOPnbWNupBu+/YIFuxflG+FAsF iQferoEeECCSaxImH0SJd5wsQrXD0pLl6Zv1nsoKe6hoPC+RECaDJ0370p7pBvg4 wt6YlUqSNANuA4h1hE6Uetu3n6M41uNnLEWBTnOtQZhxVsUcC4m4jqtR59VwG5MF ZjLZAox4IPlzMt50P3ziueMKwgiVk9SZ4g9BN1v7v9O7tcl3HLZ/Yt1blibwjyUT dx3RvkbQ6iucjqyUfRmZjZAmnOOT0zNNcxxnVMBVR2O29fYNau41QFkdVOPnazzc LaeiUC7II+Y/ZA6jyB7O49+S77c9/INPlzJrAZTAsytZuwU91QUeIj/1lKdi1c6Q WTe946Ytb2LrCU+zvMyl =zHEy -----END PGP SIGNATURE----- --Apple-Mail=_D7C94696-EF5C-4348-9F24-E05CC351FC5C--