From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Sep 15 15:20:08 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 494091065670 for ; Tue, 15 Sep 2009 15:20:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 228E08FC1C for ; Tue, 15 Sep 2009 15:20:08 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n8FFK7cx014732 for ; Tue, 15 Sep 2009 15:20:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n8FFK79t014731; Tue, 15 Sep 2009 15:20:07 GMT (envelope-from gnats) Resent-Date: Tue, 15 Sep 2009 15:20:07 GMT Resent-Message-Id: <200909151520.n8FFK79t014731@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "George D." Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2149D106566B for ; Tue, 15 Sep 2009 15:11:01 +0000 (UTC) (envelope-from gi@serv.azagal.com) Received: from smtp2.electronicbox.net (smtp.electronicbox.net [69.28.239.23]) by mx1.freebsd.org (Postfix) with ESMTP id EC1398FC24 for ; Tue, 15 Sep 2009 15:11:00 +0000 (UTC) Received: from azagal.com (62-35-97-65-CableMTL.3menatwork.com [65.97.35.62]) by smtp2.electronicbox.net (Postfix) with SMTP id A343B410599 for ; Tue, 15 Sep 2009 10:44:31 -0400 (EDT) Received: (qmail 20824 invoked from network); 15 Sep 2009 14:43:44 -0000 Received: from unknown (HELO serv.azagal.com) (127.0.0.1) by localhost.azagal.com with SMTP; 15 Sep 2009 14:43:44 -0000 Received: (from root@localhost) by serv.azagal.com (8.14.3/8.14.3/Submit) id n8FEhiKJ020822; Tue, 15 Sep 2009 10:43:44 -0400 (EDT) (envelope-from gi) Message-Id: <200909151443.n8FEhiKJ020822@serv.azagal.com> Date: Tue, 15 Sep 2009 10:43:44 -0400 (EDT) From: "George D." To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/138846: www/apache22 mod_proxy optional patch is not applied by the Makefile X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "George D." List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Sep 2009 15:20:08 -0000 >Number: 138846 >Category: ports >Synopsis: www/apache22 mod_proxy optional patch is not applied by the Makefile >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Sep 15 15:20:07 UTC 2009 >Closed-Date: >Last-Modified: >Originator: George D. >Release: FreeBSD 7.2-RELEASE i386 >Organization: >Environment: System: FreeBSD 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Tue May 12 07:24:33 EDT 2009 gi@serv.azagal.com:/usr/obj/usr/src/sys/serv_KERN i386 >Description: The optional patch for the mod_proxy_connect which can be enabled and disabled throught the config options is not getting applied regardless of whether the option is turned on or off. This is happening because the Makefile is checking for a wrong variable and not setting the EXTRA_PATCHES variable. >How-To-Repeat: The following steps reproduce the issue: - cd into the www/apache22 folder - run "make extract" - save the modules/proxy/mod_proxy_connect.c file to a different location - run "make config" - check that the PATCH_PROXY_CONNECT option is turned on - run "make patch" - check that the modules/proxy/mod_proxy_connect.c file has not changed compared to the original file >Fix: Apply the following patch to the www/apache22/Makefile : --- Makefile.org 2009-09-15 08:35:07.000000000 -0400 +++ Makefile 2009-09-15 08:35:32.000000000 -0400 @@ -189,7 +189,7 @@ show-options: @${SED} -ne 's/^##//p' ${APACHEDIR}/Makefile.doc #optionally enable mod_proxy_connect patch -.if defined(PATCH_PROXY_CONNECT) +.if defined(WITH_PATCH_PROXY_CONNECT) EXTRA_PATCHES+= ${FILESDIR}/opt-patch-modules:proxy:mod_proxy_connect.c .endif >Release-Note: >Audit-Trail: >Unformatted: