Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Jul 2017 01:25:51 +0000 (UTC)
From:      David C Somayajulu <davidcs@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r321498 - stable/10/sys/dev/qlxgbe
Message-ID:  <201707260125.v6Q1Pp8F096295@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: davidcs
Date: Wed Jul 26 01:25:51 2017
New Revision: 321498
URL: https://svnweb.freebsd.org/changeset/base/321498

Log:
  MFC 320705
  Release mtx hw_lock before calling pause() in qla_stop() and
  qla_error_recovery()

Modified:
  stable/10/sys/dev/qlxgbe/ql_os.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/qlxgbe/ql_os.c
==============================================================================
--- stable/10/sys/dev/qlxgbe/ql_os.c	Wed Jul 26 01:23:35 2017	(r321497)
+++ stable/10/sys/dev/qlxgbe/ql_os.c	Wed Jul 26 01:25:51 2017	(r321498)
@@ -1524,8 +1524,11 @@ qla_stop(qla_host_t *ha)
 
 	ha->flags.qla_watchdog_pause = 1;
 
-	while (!ha->qla_watchdog_paused)
+	while (!ha->qla_watchdog_paused) {
+		QLA_UNLOCK(ha);
 		qla_mdelay(__func__, 1);
+		QLA_LOCK(ha);
+	}
 
 	ha->flags.qla_interface_up = 0;
 
@@ -1920,7 +1923,10 @@ qla_error_recovery(void *context, int pending)
 	if (ha->flags.qla_interface_up) {
 
 		ha->hw.imd_compl = 1;
+
+		QLA_UNLOCK(ha);
 		qla_mdelay(__func__, 300);
+		QLA_LOCK(ha);
 
 	        ifp->if_drv_flags &= ~(IFF_DRV_OACTIVE | IFF_DRV_RUNNING);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201707260125.v6Q1Pp8F096295>