Date: Sat, 20 Feb 2021 12:54:21 -1000 From: Romain =?iso-8859-1?Q?Tarti=E8re?= <romain@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r566124 - in head/irc: . catgirl Message-ID: <YDGTIXSbb2A4oMMt@blogreen.org> In-Reply-To: <20210220061956.GB66080@FreeBSD.org> References: <202102192353.11JNrMtX005757@repo.freebsd.org> <20210220061956.GB66080@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--DxYemG/XL5oMIDHE
Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sat, 20 Feb 2021 12:54:21 -1000
From: Romain =?iso-8859-1?Q?Tarti=E8re?= <romain@freebsd.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
svn-ports-head@freebsd.org
Subject: Re: svn commit: r566124 - in head/irc: . catgirl
Hi!
On Sat, Feb 20, 2021 at 06:19:56AM +0000, Alexey Dokuchaev wrote:
> > +.if ${SSL_DEFAULT} =3D=3D base || ${SSL_DEFAULT} =3D=3D openssl
> > +LIB_DEPENDS+=3D libtls.so:security/libretls
> > +.endif
>=20
> I don't think this is right, or even allowed. Can't the code be made
> portable across all SSL flavors?
Hum... This program is developed targeting libressl which provide this
libretls library to ease-up development of TLS related things.
The author extracting the libretls stuff from libressl so that it can be
used with openssl, and that was imported in the ports tree as
security/libretls. My feeling is that it was better to have support for
all supported ssl versions supported by FreeBSD than just libressl so I
ended up proposing this which seemed to do the right thing (see PR
246818 for more details).
Do you see an alternative I did not think about?
Thanks!
Romain
--=20
Romain Tarti=E8re <romain@FreeBSD.org> http://people.FreeBSD.org/~romain/
pgp: 8234 9A78 E7C0 B807 0B59 80FF BA4D 1D95 5112 336F (ID: 0x5112336F)
(plain text =3Dnon-HTML=3D PGP/GPG encrypted/signed e-mail much appreciated)
--DxYemG/XL5oMIDHE
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQGzBAABCAAdFiEEgjSaeOfAuAcLWYD/uk0dlVESM28FAmAxkx4ACgkQuk0dlVES
M2/2RAv8CBXQIlDunfLCan/ZKoJDq9HOMPV9xJhfXHT1fGsfINX2gKcA/TV1xtQb
KHO1D4hnOCkdz+ZPsljaxmyDnkdmRzZooBCR0RaJOt7Nc9FeZ1aBMWxEDlJmg+ap
e1hsL0I8snbMLFFywgFLll/CUPs1jQdlpogN1KVAZ8cudLQtOFB415yGtT0LPgq+
+QhQ7m/SDRIcHpHhLmROrT+WXX330mey7n9TdJ7bmiqUnoUgg2lEGe7g4VRXlWgL
kTgftz6/kTUS4+S9NrdATDBsb8TtxQyqO18QO9rhk0QdaTL2XOo5doNGJYNp3oLj
VD+7ZpM8wVYejdcpftEbDmqAltknccxYnXtHKz6uBSlYVjXrObsD31IX1CCHVBzX
nv3GclQNzvv7kpuG3nzEOiqEl5Zp4Q6PX7ir3LTHo3BvUYuBi0YypD+nqrXnqn3o
oM/DHjz6k6V/iYU+mQXeri8vWVl3JSezFmv9n0TiZHBZHmvz1r/Qunn1B15MhDvi
lmJCIDq2
=o+BH
-----END PGP SIGNATURE-----
--DxYemG/XL5oMIDHE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YDGTIXSbb2A4oMMt>