From owner-svn-src-head@freebsd.org  Thu Oct  1 17:03:13 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 247BBA0DCF1;
 Thu,  1 Oct 2015 17:03:13 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 034C0146E;
 Thu,  1 Oct 2015 17:03:13 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 10CC7B913;
 Thu,  1 Oct 2015 13:03:12 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: src-committers@freebsd.org
Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r288452 - head/sys/dev/drm2/i915
Date: Thu, 01 Oct 2015 10:01:20 -0700
Message-ID: <90323889.l5UMs3tJRz@ralph.baldwin.cx>
User-Agent: KMail/4.14.3 (FreeBSD/10.2-PRERELEASE; KDE/4.14.3; amd64; ; )
In-Reply-To: <201510011659.t91Gx8SX094039@repo.freebsd.org>
References: <201510011659.t91Gx8SX094039@repo.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Thu, 01 Oct 2015 13:03:12 -0400 (EDT)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Oct 2015 17:03:13 -0000

On Thursday, October 01, 2015 04:59:08 PM John Baldwin wrote:
> Author: jhb
> Date: Thu Oct  1 16:59:07 2015
> New Revision: 288452
> URL: https://svnweb.freebsd.org/changeset/base/288452
> 
> Log:
>   Most error cases in i915_gem_do_execbuffer() jump to one of two labels to
>   release resources (such as unholding pages) when errors occur.  Some
>   recently added error checks return immediately instead of jumping to a
>   label resulting in leaks.  Fix these to jump to a label to do cleanup
>   instead.

I was getting panics due to the hold count on pages being negative in this
function.  The hold counts were quiet high and so I believe that the hold
count overflowed to zero due to these leaks and triggered the panic.

-- 
John Baldwin