From owner-p4-projects@FreeBSD.ORG Fri Mar 27 20:19:01 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 849BF1065675; Fri, 27 Mar 2009 20:19:01 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3C6861065674 for ; Fri, 27 Mar 2009 20:19:01 +0000 (UTC) (envelope-from trasz@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 0FDF18FC14 for ; Fri, 27 Mar 2009 20:19:01 +0000 (UTC) (envelope-from trasz@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n2RKJ0R4043211 for ; Fri, 27 Mar 2009 20:19:00 GMT (envelope-from trasz@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n2RKJ0JF043209 for perforce@freebsd.org; Fri, 27 Mar 2009 20:19:00 GMT (envelope-from trasz@freebsd.org) Date: Fri, 27 Mar 2009 20:19:00 GMT Message-Id: <200903272019.n2RKJ0JF043209@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to trasz@freebsd.org using -f From: Edward Tomasz Napierala To: Perforce Change Reviews Cc: Subject: PERFORCE change 159923 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2009 20:19:02 -0000 http://perforce.freebsd.org/chv.cgi?CH=159923 Change 159923 by trasz@trasz_victim7 on 2009/03/27 20:18:17 Formatting fixes. Also, get rid of VALLPERMS; it's not used for anything. Affected files ... .. //depot/projects/soc2008/trasz_nfs4acl/sys/sys/vnode.h#21 edit Differences ... ==== //depot/projects/soc2008/trasz_nfs4acl/sys/sys/vnode.h#21 (text+ko) ==== @@ -310,33 +310,30 @@ /* * Flags for accmode_t. */ -#define VEXEC 000000000100 /* execute/search permission */ -#define VWRITE 000000000200 /* write permission */ -#define VREAD 000000000400 /* read permission */ -#define VADMIN 000000010000 /* being the file owner */ -#define VSTAT 000000020000 /* permission to retrieve attrs */ -#define VAPPEND 000000040000 /* permission to write/append */ +#define VEXEC 000000000100 /* execute/search permission */ +#define VWRITE 000000000200 /* write permission */ +#define VREAD 000000000400 /* read permission */ +#define VADMIN 000000010000 /* being the file owner */ +#define VSTAT 000000020000 /* permission to retrieve attrs */ +#define VAPPEND 000000040000 /* permission to write/append */ /* - * Return EPERM or EACCES only if permission was denied explicitly, - * by a "deny" rule in NFS4 ACL. This never happens with ordinary - * unix access rights or POSIX.1e ACLs. Obviously, VEXPLICIT_DENY - * must be OR-ed with some other Vflag. + * VEXPLICIT_DENY makes VOP_ACCESS(9) return EPERM or EACCES only + * if permission was denied explicitly, by a "deny" rule in NFS4 ACL, + * and 0 otherwise. This never happens with ordinary unix access rights + * or POSIX.1e ACLs. Obviously, VEXPLICIT_DENY must be OR-ed with + * some other V* constant. */ #define VEXPLICIT_DENY 000000100000 -#define VREAD_NAMED_ATTRS 000000200000 /* not used */ -#define VWRITE_NAMED_ATTRS 000000400000 /* not used */ +#define VREAD_NAMED_ATTRS 000000200000 /* not used */ +#define VWRITE_NAMED_ATTRS 000000400000 /* not used */ #define VDELETE_CHILD 000001000000 -#define VREAD_ATTRIBUTES 000002000000 -#define VWRITE_ATTRIBUTES 000004000000 +#define VREAD_ATTRIBUTES 000002000000 /* permission to stat(2) */ +#define VWRITE_ATTRIBUTES 000004000000 /* change {m,c,a}time */ #define VDELETE 000010000000 -#define VREAD_ACL 000020000000 -#define VWRITE_ACL 000040000000 -#define VWRITE_OWNER 000100000000 -#define VSYNCHRONIZE 000200000000 /* not used */ -#define VALLPERM (VEXEC | VWRITE | VREAD | VADMIN | VSTAT | VAPPEND \ - VEXPLICIT_DENY | VREAD_NAMED_ATTRS | VWRITE_NAMED_ATTRS | VDELETE_CHILD \ - VREAD_ATTRIBUTES | VWRITE_ATTRIBUTES | VDELETE | VREAD_ACL | VWRITE_ACL \ - VWRITE_OWNER | VSYNCHRONIZE) +#define VREAD_ACL 000020000000 /* read ACL and file mode */ +#define VWRITE_ACL 000040000000 /* change ACL and/or file mode */ +#define VWRITE_OWNER 000100000000 /* change file owner */ +#define VSYNCHRONIZE 000200000000 /* not used */ /* * Permissions that were traditionally granted only to the file owner.