From owner-cvs-all Tue Feb 26 11:20:52 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc52.attbi.com (rwcrmhc52.attbi.com [216.148.227.88]) by hub.freebsd.org (Postfix) with ESMTP id 9F8D137B402; Tue, 26 Feb 2002 11:20:38 -0800 (PST) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc52.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020226192038.NMHT1147.rwcrmhc52.attbi.com@InterJet.elischer.org>; Tue, 26 Feb 2002 19:20:38 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA95092; Tue, 26 Feb 2002 11:14:28 -0800 (PST) Date: Tue, 26 Feb 2002 11:14:28 -0800 (PST) From: Julian Elischer To: Matthew Dillon Cc: Jake Burkholder , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 exception.s genassym.c machdep.c mp_machdep.c mpapic.c swtch.s vm_machdep.c src/sys/i386/include cpufunc.h pcb.h src/sys/i386/isa apic_vector.s clock.c icu_vector.s intr_machdep.c intr_machdep.h npx.c src/sys/kern ... In-Reply-To: <200202261806.g1QI6GL94130@apollo.backplane.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Amen John is doing good stuff but he can not expect the world to stop while he works away at the back of some cave in Afganistan. He needs to commit, and often. On Tue, 26 Feb 2002, Matthew Dillon wrote: > :> vm_machdep.c > :> sys/i386/include cpufunc.h pcb.h > :> sys/i386/isa apic_vector.s clock.c icu_vector.s > :> intr_machdep.c intr_machdep.h npx.c > :> sys/kern kern_fork.c kern_switch.c > :> sys/sys pcpu.h > :> Log: > :> STAGE-1 of 3 commit - allow (but do not require) interrupts to remain > :> enabled in critical sections and streamline critical_enter() and > :> critical_exit(). > :> > : > :This patch was in dispute and still being discussed. Both jhb and bde > :had issues with it which were not resolved. It should not have been > :committed until these issues were resolved. This does not set a very > :good precedent for developer relations. Please back it out. > : > :Jake > > I will not back it out. JHB has had issues with every single goddamn > thing I've tried to do that has been SMP related. JHB has had > patches going stale in P4 related to just about every file I've ever > had to touch. > > He has cried wolf one too many times. It is totally inappropriate for > JHB to put a lock on the entire SMP subsystem. > > JHB needs to get his act together. > > -Matt > Matthew Dillon > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message