From owner-svn-src-all@FreeBSD.ORG Thu Jul 29 00:53:15 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D7E741065679 for ; Thu, 29 Jul 2010 00:53:15 +0000 (UTC) (envelope-from joerg@britannica.bec.de) Received: from www.sonnenberger.org (www.sonnenberger.org [92.79.50.50]) by mx1.freebsd.org (Postfix) with ESMTP id 939B68FC15 for ; Thu, 29 Jul 2010 00:53:15 +0000 (UTC) Received: from britannica.bec.de (www.sonnenberger.org [192.168.1.10]) by www.sonnenberger.org (Postfix) with ESMTP id 6A6E26676C for ; Thu, 29 Jul 2010 02:34:34 +0200 (CEST) Received: by britannica.bec.de (Postfix, from userid 1000) id D08841509E; Thu, 29 Jul 2010 02:34:29 +0200 (CEST) Date: Thu, 29 Jul 2010 02:34:29 +0200 From: Joerg Sonnenberger To: svn-src-all@freebsd.org Message-ID: <20100729003429.GA6430@britannica.bec.de> References: <201007290011.o6T0BE0l072516@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201007290011.o6T0BE0l072516@svn.freebsd.org> User-Agent: Mutt/1.5.20 (2009-06-14) Subject: Re: svn commit: r210578 - head/usr.bin/grep X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2010 00:53:15 -0000 On Thu, Jul 29, 2010 at 12:11:14AM +0000, Gabor Kovesdan wrote: > - Some improvements on the exiting code, like replacing memcpy with > strlcpy/strcpy Why is this an improvement? At least for non-trivial sizes, it is quite likely to be a regression. Especially using strlcpy as replacement for memcpy+\0 is bogus. Joerg