From owner-svn-src-head@freebsd.org Thu Jun 23 00:39:49 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D117CB7264C; Thu, 23 Jun 2016 00:39:49 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AD21C13DE; Thu, 23 Jun 2016 00:39:49 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 749475A9F2A; Thu, 23 Jun 2016 00:39:48 +0000 (UTC) Date: Thu, 23 Jun 2016 00:39:48 +0000 From: Brooks Davis To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302094 - in head/sys: compat/freebsd32 kern Message-ID: <20160623003948.GB41630@spindle.one-eyed-alien.net> References: <201606222115.u5MLFxBD093628@repo.freebsd.org> <5096414.4TN0ypqLNM@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5/uDoXvLw7AC5HRs" Content-Disposition: inline In-Reply-To: <5096414.4TN0ypqLNM@ralph.baldwin.cx> User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2016 00:39:49 -0000 --5/uDoXvLw7AC5HRs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 22, 2016 at 05:09:34PM -0700, John Baldwin wrote: > On Wednesday, June 22, 2016 09:15:59 PM Brooks Davis wrote: > > Author: brooks > > Date: Wed Jun 22 21:15:59 2016 > > New Revision: 302094 > > URL: https://svnweb.freebsd.org/changeset/base/302094 > >=20 > > Log: > > Mark the pipe() system call as COMPAT10. > > =20 > > As of r302092 libc uses pipe2() with a zero flags value instead of pi= pe(). > > =20 > > Commit with regenerated files and implementation to follow. >=20 > This breaks the build on at least i386 because other ABIs depend on being > able to call sys_pipe directly. You should at least add COMPAT_FREEBSD10 > to GENERIC on architectures that shipped a 10.x release. That will fix t= he > build breakage on i386, but it's also the policy we follow for all the ot= her > compat knobs. It was actually that sys_pipe() was renamed by the COMPAT10 tag. I've copied the implementation to a svr4_pipe(). -- Brooks --5/uDoXvLw7AC5HRs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXay/TAAoJEKzQXbSebgfAUwkIAI+9MNKDIAiT4QUcT+7yGNMb wBMrSkCbjaWjxUc5DVUjjL3uPMtx+dfFIAW8JR7KSpQytqfI0rKDVcHJbDNRrivx Np/X+cJbmNXUJUKltgS+31XotNR6nmA0UoARslVPTBklF6+3BfjJ9pSGOGzYEuyc vQT/mSMX8NK3TUhDqKeXGtPWvxA0yjMdDflUnlnEm0zXQPlggpnG6j3BBkabSdLy +AJIoYk5aNj2SdtH+3noH5tP2YF4oB2m6hwn6OrIVC43jey0+VvalalMHhkaGIPK u4Qev1/r8f4V3/2yzNwBvj3TXayKfXc35Q3mn6Duhr94LiPx1GuxUkcgdtbwcYg= =SHFd -----END PGP SIGNATURE----- --5/uDoXvLw7AC5HRs--