From owner-freebsd-hackers Wed Mar 6 11:38:15 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 7E63837B402 for ; Wed, 6 Mar 2002 11:38:10 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.12.1/8.12.1) with ESMTP id g26JbkOJ108138; Wed, 6 Mar 2002 14:37:47 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <26424.1015440592@critter.freebsd.dk> References: <26424.1015440592@critter.freebsd.dk> Date: Wed, 6 Mar 2002 14:37:45 -0500 To: Poul-Henning Kamp From: Garance A Drosihn Subject: Re: RFC: style(9) isn't explicit about booleans for testing. Cc: "Mike Meyer" , hackers@FreeBSD.ORG Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 7:49 PM +0100 3/6/02, Poul-Henning Kamp wrote: >Garance A Drosihn writes: > >In one message, >> At 12:52 AM -0800 3/6/02, David O'Brien wrote: >>>I don't think it is clarifying a rule. I think it is in fact adding >>>a rule. You are extrapolating too much I think. All the rule is >>>trying to prevent is "if (!strcmp(a,b))" which when read is extremely > >>wrong of that is actually happening. > > > >If we change boolean to integer, then the proposed rule will not >>prevent "if (!strcmp(a,b))" , because strcmp() *does* return an >>integer value. Or am I missing something here? > >Right, and since the integer is well defined, > if (!strcmp(a, b)) >is perfectly understandable so what is the problem ? Well, that's my question. David's comment implies that it is not good to do '!strcmp()', and I was wondering why it is not good... -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message