From owner-freebsd-stable@FreeBSD.ORG Fri Apr 15 05:32:44 2005 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B88A16A4CE for ; Fri, 15 Apr 2005 05:32:44 +0000 (GMT) Received: from smtp.owt.com (smtp.owt.com [204.118.6.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD79F43D1D for ; Fri, 15 Apr 2005 05:32:43 +0000 (GMT) (envelope-from kstewart@owt.com) Received: from [207.41.94.233] (owt-207-41-94-233.owt.com [207.41.94.233]) by smtp.owt.com (8.12.8/8.12.8) with ESMTP id j3F5VxUF028927 for ; Thu, 14 Apr 2005 22:31:59 -0700 From: Kent Stewart To: freebsd-stable@freebsd.org Date: Thu, 14 Apr 2005 22:32:42 -0700 User-Agent: KMail/1.8 References: <425E7DBD.8060107@alumni.rice.edu> <425EB486.5090001@root.org> <20050415131817.E89F.REES@ddcom.co.jp> In-Reply-To: <20050415131817.E89F.REES@ddcom.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200504142232.42274.kstewart@owt.com> Subject: Re: RELENG_5 broken? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2005 05:32:44 -0000 On Thursday 14 April 2005 09:23 pm, Joel wrote: > On Thu, 14 Apr 2005 11:20:54 -0700 > Nate Lawson wrote > > > Jon Noack wrote: > > > On 4/14/2005 8:28 AM, David Wolfskill wrote: > > >> On Thu, Apr 14, 2005 at 01:26:17PM +0200, Jose M Rodriguez wrote: > > >>> Anyone seen this? > > >> > > >> [... > > >> /usr/src/sys/kern/subr_bus.c:1082: warning: no previous > > >> prototype for 'devclass_get_drivers' > > >> *** Error code 1 > > >> ... > > >> ] > > >> > > >> Yup; just a few minutes ago, with sys/kern/subr_bus.c rev. > > >> 1.156.2.6. > > >> > > >> Perhaps something was overlooked in the MFC from 2005-04-14 > > >> 04:54:15 UTC? > > > > > > Yeah, we also need to MFC rev. 1.68 of src/sys/sys/bus.h. > > > > I've committed the prototype, much apologies for the breakage. I > > compiled the patch in my RELENG_5 tree just fine, but it appears > > the kernel build may be referencing /sys for includes instead of > > ../../../sys or whatever. Thus build-testing MFC patches on a > > -current box is not a good test. > > Okay, I started a build makeworld in /usr/src last night, and then > build make kernel hits this. > > What do we do next? Is it okay to go back to cvsup, and will that > pick up the changes? > Joel, Can I give you a bad time. We were always told that if you follow x-stable, you were to follow cvs-all. Then, you would have seen his fix committed around 1811 UTC. FWIW, you are just in time anyway because they added a security notice and if you cvsup now, you will also get that fix. Kent -- Kent Stewart Richland, WA http://users.owt.com/kstewart/index.html