From owner-freebsd-current  Tue Sep  1 23:14:29 1998
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id XAA20909
          for freebsd-current-outgoing; Tue, 1 Sep 1998 23:14:29 -0700 (PDT)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from rf900.physics.usyd.edu.au (rf900.physics.usyd.edu.au [129.78.129.109])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA20889
          for <freebsd-current@FreeBSD.ORG>; Tue, 1 Sep 1998 23:14:15 -0700 (PDT)
          (envelope-from dawes@rf900.physics.usyd.edu.au)
Received: (from dawes@localhost) by rf900.physics.usyd.edu.au (8.8.5/8.8.2) id QAA22404; Wed, 2 Sep 1998 16:13:03 +1000 (EST)
Message-ID: <19980902161303.E21469@rf900.physics.usyd.edu.au>
Date: Wed, 2 Sep 1998 16:13:03 +1000
From: David Dawes <dawes@rf900.physics.usyd.edu.au>
To: Joachim Kuebart <joki@kuebart.stuttgart.netsurf.de>
Cc: roberto@keltia.freenix.fr, freebsd-current@FreeBSD.ORG
Subject: Re: XFree86 and ELF
Mail-Followup-To: Joachim Kuebart <joki@kuebart.stuttgart.netsurf.de>,
	roberto@keltia.freenix.fr, freebsd-current@FreeBSD.ORG
References: <19980902123708.A21469@rf900.physics.usyd.edu.au> <199809020539.HAA01414@yacht.domestic.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.91.1i
In-Reply-To: <199809020539.HAA01414@yacht.domestic.de>; from Joachim Kuebart on Wed, Sep 02, 1998 at 07:39:53AM +0200
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Wed, Sep 02, 1998 at 07:39:53AM +0200, Joachim Kuebart wrote:
>David Dawes wrote:
>> Can I ask a naive question?  Is there any reason the FreeBSD/ELF rules
>> need to be different from those used for Linux/ELF (see lnxLib.cf)?  Also,
>> please keep in mind that bsdLib.rules is used for NetBSD and OpenBSD too.
>
>I haven't really looked at the Linux rules closely enough to comment
>on that. However, if they could be used it would be worth a little
>work.
>
>> >> > -#if defined(Lynx) || (defined(SYSV) || defined(SVR4)) && !defined(ACK_ASSEMBLER) || (defined(linux) || defined(__OS2ELF__)) && defined(__ELF__)
>> >> > +#if defined(Lynx) || (defined(SYSV) || defined(SVR4)) && !defined(ACK_ASSEMBLER) || (defined(__FreeBSD__) || defined(linux) || defined(__OS2ELF__)) && defined(__ELF__)
>> 
>> My preference here is to remove the OS checks, which should simplify that
>> #ifdef a bit.
>
>To be honest I thought of that change but was afraid to do it. I don't
>understand why it isn't simply '#ifdef __ELF__' in the first place, so
>I was afraid to break things for somebody else.

I'm pretty sure that's why others did it that way too.  I think it is safe
to simplify it to:

#if defined(Lynx) || (defined(SYSV) || defined(SVR4)) && !defined(ACK_ASSEMBLER) || defined(__ELF__)

If something does break as a consequence, we (XFree86) will deal with it.

David

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message