From owner-svn-src-all@freebsd.org Tue Sep 20 04:08:45 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C0027BDF6CA for ; Tue, 20 Sep 2016 04:08:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 86487F5 for ; Tue, 20 Sep 2016 04:08:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22f.google.com with SMTP id m186so8159710ioa.2 for ; Mon, 19 Sep 2016 21:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=9iAbiz28cbGfO4EXxfBJtcZkeSyKJ0FH3HYMSkqSY2o=; b=yYrg9vGWzXPYh5hPAZy4fRjn3AzIPGosMGHfL5uaj4RA7EjirK1jl88oczmKqv1CTp lJocfP0zoK7HmNi+uyWaD0GU7O8JCVf5QAiin37ZtA5SXdp6VE9SY+9Nv2B4JtExz43A wmvbckKEVystngb0YQ0LwbL5PBKoCWFExZILZt/3ICAyEib92Q0rDRVUAFm4FlWmBIQK YTf+RnLLx8/S474Vdpa1zshXWcefN5PoTN3uTjqpxRgtRVBHzqG6JLYx8Xwv44ayezti MpsLCkCslvccASF3UGLT+lR4h2bdDB9k5nM/AmCFnC6TcxlF4BDQR7jEYst+n5gDL0Rm 8BXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=9iAbiz28cbGfO4EXxfBJtcZkeSyKJ0FH3HYMSkqSY2o=; b=ClW3MmBxmVtcCrJ26upQgSR2umTOaN/E+EYUpkoBx//PuMe3mbK9lOgu4sgaJoNx/T HaVD/18PG5tPzSL378iGCwJwqVnWpx2Hx9YTczPvsJ0mLKRyOw9AzYMIJIiyA5UTFq5o DCgwFSZuWivGEEHwXs5V9ZnlJ7FPMaC1fmO2WkNEvrZ7308uv12FaIyohC6PEd88dBEr u8BFWGIPlB2QKUkDRMI3ysmYVkDIeQfX1/MXu8Ei2MeyGwlsFkH/YWYOLC0XTwtmeRDD k6fLF9jfnN/UYxSKZwnFRJLTTj/uk7kX4zhPNgxhlHck1r/PGVR6X7lebx97l0GKXEWr iqjw== X-Gm-Message-State: AE9vXwPRCOiVUzyT3cLf6yvSEeY2LFKWw8+/SzgKUG/46MV1iQK6mMs9+Y3/CRuuySrzZd3ejJEwJEPuWtzzIQ== X-Received: by 10.107.168.195 with SMTP id e64mr22564592ioj.205.1474344524950; Mon, 19 Sep 2016 21:08:44 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.36.65.7 with HTTP; Mon, 19 Sep 2016 21:08:44 -0700 (PDT) X-Originating-IP: [69.53.245.200] In-Reply-To: References: <201609192043.u8JKh3jv040006@repo.freebsd.org> From: Warner Losh Date: Mon, 19 Sep 2016 22:08:44 -0600 X-Google-Sender-Auth: xR7qvaLn8caB-9d8gIyLBy4HHkk Message-ID: Subject: Re: svn commit: r305998 - in head/usr.bin: cmp indent tr To: "Conrad E. Meyer" Cc: "Ngie Cooper (yaneurabeya)" , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 04:08:45 -0000 If you read style(9) as an annotated example of best practices, you'll see that it is actually documented there, but poorly. It's the first one after cdefs for the FreeBSD ID. It says to include one or the other, with the implication it's first. It's the common interpretation of the project (this issue has come up before) and it's just one tiny sliver of tribal knowledge that was attempted to be enshrined there. Yes, it isn't explicit, but it matches convention in the rest of the tree. Maybe it should be explicit, but it's always a shit-show when people tinker with style(9) to make it "clearer" because other people think you did it wrong, or need to list a big set of exceptions to the rule or who knows what. Hell, I couldn't even add that {} were allowed in contexts where people had been using them for a decade without it being a stupid bikeshed and despite extremely careful vetting and consensus building I have been told that one committer left the project over it. So I'd think twice about modifying style.9 and go have a beer or your favorite relaxing beverage instead. Warner On Mon, Sep 19, 2016 at 3:03 PM, Conrad Meyer wrote: > If you re-read the sentences you've pasted carefully, I think you'll > find it doesn't actually say that the types or param headers come > before other sys/ headers. Just that sys/ headers come before > non-sys/ headers. > > Best, > Conrad > > On Mon, Sep 19, 2016 at 1:45 PM, Ngie Cooper (yaneurabeya) > wrote: >> >> On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer wrote: >> >> Author: cem >> Date: Mon Sep 19 20:43:03 2016 >> New Revision: 305998 >> URL: https://svnweb.freebsd.org/changeset/base/305998 >> >> Log: >> Move sys/capsicum.h includes after types.h or param.h >> >> This is not actually documented or even implied in style(9). Make the >> change >> to match convention. Someone should document this convention in style(= 9). >> >> Reported by: jhb >> Sponsored by: EMC Dell Isilon >> >> >> Uh=E2=80=A6 yes it clearly states it in style(9). From >> https://www.freebsd.org/cgi/man.cgi?query=3Dstyle&sektion=3D9 : >> >> Kernel include files (i.e. sys/*.h) come first; normally, include >> OR , but not both. includ= es >> , and it is okay to depend on that. >> >> Thanks, >> -Ngie >