From owner-freebsd-acpi@FreeBSD.ORG  Mon Jul 26 17:09:02 2004
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0162916A4CE
	for <freebsd-acpi@freebsd.org>; Mon, 26 Jul 2004 17:09:02 +0000 (GMT)
Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C5BD943D5C
	for <freebsd-acpi@freebsd.org>; Mon, 26 Jul 2004 17:09:01 +0000 (GMT)
	(envelope-from nate@root.org)
Received: from [10.0.0.34] (adsl-67-127-84-57.dsl.snfc21.pacbell.net
	[67.127.84.57])
	by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i6QH8wrb003795
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Mon, 26 Jul 2004 10:09:01 -0700
Message-ID: <41053A0C.8010906@root.org>
Date: Mon, 26 Jul 2004 10:06:20 -0700
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: takawata@jp.freebsd.org
References: <200407251928.i6PJS8mD089499@sana.init-main.com>
In-Reply-To: <200407251928.i6PJS8mD089499@sana.init-main.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: freebsd-acpi@freebsd.org
Subject: Re: ThinkPad X31 Hotkey device
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Jul 2004 17:09:02 -0000

takawata@jp.freebsd.org wrote:
> Hi, I wrote a ThinkPad Hot key device driver.
> This will send hot key event for devd and 
> display debug message when hot key event is
> recognized.
> I tested on ThinkPad X31 and 
> not tested on ThinkPad i1620 but should work on it.
> 
> http://www.init-main.com/acpi_tpkey/

Thanks!  Some comments:

* New drivers should use style(9) (especially 8 space tabs)
* acpi_tpkey_call_{get,set}_method() should be replaced with 
acpi_{Get,Set}Integer() (see acpi.c)
* No need to call acpi_get_type() in the probe method -- the 
ACPI_PNP_PROBE function handles this.
* SYSCTL_OUT/IN can be replaced by sysctl_handle_int.

See acpi_toshiba.c for good examples of all this.

-- 
-Nate