From owner-svn-ports-all@FreeBSD.ORG  Sat Jun 14 17:52:53 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D94978F3;
 Sat, 14 Jun 2014 17:52:53 +0000 (UTC)
Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client CN "mouf.net", Issuer "mouf.net" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 99EAB221A;
 Sat, 14 Jun 2014 17:52:53 +0000 (UTC)
Received: from mouf.net (swills@mouf [199.48.129.64])
 by mouf.net (8.14.5/8.14.5) with ESMTP id s5EHqi1H068134
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
 Sat, 14 Jun 2014 17:52:49 GMT (envelope-from swills@mouf.net)
Received: (from swills@localhost)
 by mouf.net (8.14.5/8.14.5/Submit) id s5EHqiUK068133;
 Sat, 14 Jun 2014 17:52:44 GMT (envelope-from swills)
Date: Sat, 14 Jun 2014 17:52:44 +0000
From: Steve Wills <swills@freebsd.org>
To: marino@freebsd.org
Subject: Re: svn commit: r357767 - head/net/cyphesis
Message-ID: <20140614175243.GD67971@mouf.net>
References: <201406141111.s5EBBCgV016094@svn.freebsd.org>
 <539C8682.3030603@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <539C8682.3030603@marino.st>
User-Agent: Mutt/1.5.22 (2013-10-16)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (mouf.net [199.48.129.64]); Sat, 14 Jun 2014 17:52:49 +0000 (UTC)
X-Spam-Status: No, score=0.0 required=4.5 tests=none autolearn=unavailable
 version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mouf.net
X-Virus-Scanned: clamav-milter 0.98.1 at mouf.net
X-Virus-Status: Clean
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Oliver Lehmann <oliver@freebsd.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jun 2014 17:52:53 -0000

On Sat, Jun 14, 2014 at 07:29:38PM +0200, John Marino wrote:
> On 6/14/2014 13:11, Oliver Lehmann wrote:
> > Author: oliver
> > Date: Sat Jun 14 11:11:11 2014
> > New Revision: 357767
> > URL: http://svnweb.freebsd.org/changeset/ports/357767
> > QAT: https://qat.redports.org/buildarchive/r357767/
> > 
> > Log:
> >   mark as BROKEN (Does not compile with clang)
> > 
> 
> 
> But FreeBSD 8 and 9 are still supported, and it builds on those:
> http://portsmon.freebsd.org/portoverview.py?category=net&portname=cyphesis
> 
> So marking this unconditionally broken breaks it on those platforms, and
> DragonFly too.
> 
> It seems to me the action to take is:
> 1) fix it so builds regardless of compiler
> 2) nothing.  (F8, F9, + DF is better than broken everywhere.

Wouldn't the right thing be to mark it broken on FreeBSD 8 and 9 only, via
conditionals?

Steve