From owner-freebsd-current@FreeBSD.ORG  Thu Sep 25 20:51:01 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1E3D41065689
	for <freebsd-current@freebsd.org>; Thu, 25 Sep 2008 20:51:01 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id EBD868FC1B
	for <freebsd-current@freebsd.org>; Thu, 25 Sep 2008 20:51:00 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTP id 8281246B03;
	Thu, 25 Sep 2008 16:51:00 -0400 (EDT)
Date: Thu, 25 Sep 2008 21:51:00 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Stefan Ehmann <shoesoft@gmx.net>
In-Reply-To: <200809250139.10332.shoesoft@gmx.net>
Message-ID: <alpine.BSF.1.10.0809252149560.18227@fledge.watson.org>
References: <200809231851.42849.shoesoft@gmx.net>
	<200809250020.38331.shoesoft@gmx.net>
	<alpine.BSF.1.10.0809242342440.68287@fledge.watson.org>
	<200809250139.10332.shoesoft@gmx.net>
User-Agent: Alpine 1.10 (BSF 962 2008-03-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-current@freebsd.org
Subject: Re: ipfw: LOR/panic with uid rules
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Sep 2008 20:51:01 -0000


On Thu, 25 Sep 2008, Stefan Ehmann wrote:

> Hmm, just obtained a new dump which was the same. Did a normal "make 
> kernel", so source/kernel should be in sync
> 
> This is the version:
> 
> __FBSDID("$FreeBSD: src/sys/netinet/tcp_input.c,v 1.382 2008/09/24 11:07:03 
> rwatson Exp $");
> 
> What doesn't match? I only checked this and it looks okay to me

Indeed, it looks like I had my own source synchronization issue :-).

This backtrace is differen from the previous one, and is for a different 
instance of the same bug.  I believe I've corrected it with this change:

rwatson     2008-09-25 17:26:54 UTC

   FreeBSD src repository

   Modified files:
     sys/netinet          tcp_input.c
   Log:
   SVN rev 183356 on 2008-09-25 17:26:54Z by rwatson

   As a follow-on to r183323, correct another case where ip_output() was
   called without an inpcb pointer despite holding the tcbinfo global
   lock, which lead to a deadlock or panic when ipfw tried to further
   acquire it recursively.

   Reported by:    Stefan Ehmann <shoesoft at gmx dot net>
   MFC after:      3 days

   Revision  Changes    Path
   1.383     +17 -1     src/sys/netinet/tcp_input.c

Could you update and see if things run better?

Thanks,

Robert N M Watson
Computer Laboratory
University of Cambridge