From owner-svn-ports-head@freebsd.org Mon Oct 17 19:03:34 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46E1CC16CAA; Mon, 17 Oct 2016 19:03:34 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D837E9EA; Mon, 17 Oct 2016 19:03:33 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 7D91BBDD18; Mon, 17 Oct 2016 21:03:31 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 4DF30BDC71; Mon, 17 Oct 2016 21:03:31 +0200 (CEST) Subject: Re: svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk spice-gtk/files To: Tijl Coosemans , John Marino References: <201610171515.u9HFF8pG092481@repo.freebsd.org> <1efd0c19-83cb-f7e9-f13a-61fac1b2c8e1@FreeBSD.org> <53c293a4-cc69-53dc-5311-54393b2f9249@marino.st> <704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org> <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st> <5a37eec4-7703-d0d9-f82e-393e1dd6543a@FreeBSD.org> <8cca7750-291e-c7c9-72aa-f91d17373046@marino.st> <20161017193939.033c999c@kalimero.tijl.coosemans.org> Cc: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: <80ac5d38-8993-2ad7-c7ea-3bb8e1b8f589@FreeBSD.org> Date: Mon, 17 Oct 2016 21:03:30 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161017193939.033c999c@kalimero.tijl.coosemans.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IL2TD9xR10U8KEkuEGRqxrPFCmbIBQaHH" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 19:03:34 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IL2TD9xR10U8KEkuEGRqxrPFCmbIBQaHH Content-Type: multipart/mixed; boundary="hauIlXNekaV9wtsKSsg0kimFbGmDixgIU"; protected-headers="v1" From: Mathieu Arnold To: Tijl Coosemans , John Marino Cc: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <80ac5d38-8993-2ad7-c7ea-3bb8e1b8f589@FreeBSD.org> Subject: Re: svn commit: r424123 - in head/deskutils: py-spice-gtk spice-gtk spice-gtk/files References: <201610171515.u9HFF8pG092481@repo.freebsd.org> <1efd0c19-83cb-f7e9-f13a-61fac1b2c8e1@FreeBSD.org> <53c293a4-cc69-53dc-5311-54393b2f9249@marino.st> <704f4b45-1b73-4bcf-9ca2-cf25eaf605b7@FreeBSD.org> <74f966d4-3bdf-0e15-9c9f-a8a4fdaac6ec@marino.st> <5a37eec4-7703-d0d9-f82e-393e1dd6543a@FreeBSD.org> <8cca7750-291e-c7c9-72aa-f91d17373046@marino.st> <20161017193939.033c999c@kalimero.tijl.coosemans.org> In-Reply-To: <20161017193939.033c999c@kalimero.tijl.coosemans.org> --hauIlXNekaV9wtsKSsg0kimFbGmDixgIU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 17/10/2016 =C3=A0 19:39, Tijl Coosemans a =C3=A9crit : > On Mon, 17 Oct 2016 12:03:44 -0500 John Marino wrote: >> On 10/17/2016 12:01, Mathieu Arnold wrote: >>> Le 17/10/2016 =C3=A0 18:31, John Marino a =C3=A9crit : =20 >>>> On 10/17/2016 11:28, Mathieu Arnold wrote: =20 >>>>> Le 17/10/2016 =C3=A0 18:26, John Marino a =C3=A9crit : =20 >>>>>> On 10/17/2016 11:20, Mathieu Arnold wrote: =20 >>>>>>> Le 17/10/2016 =C3=A0 17:55, John Marino a =C3=A9crit : =20 >>>>>>>> On 10/17/2016 10:52, Mathieu Arnold wrote: =20 >>>>>>>>> Le 17/10/2016 =C3=A0 17:15, John Marino a =C3=A9crit : =20 >>>>>>>>>> Apparently USES=3Dpathfix and USES=3Dautoreconf can't be use= d >>>>>>>>>> together, so >>>>>>>>>> the pkgconfig directory is now passed via MAKE_ARGS =20 >>>>>>>>> That is mostly not true. What usage makes it so that they do no= t >>>>>>>>> work >>>>>>>>> together ? =20 >>>>>>>> The results suggest that "${WRKSRC}/configure" was modified, the= n >>>>>>>> autoreconf regenerated ${WRKSRC}/configure afterwards so that th= e >>>>>>>> pkgconfig path change was reverted. >>>>>>>> >>>>>>>> That's why I had to replace pathfix with MAKE_ARGS. =20 >>>>>>> No, USES=3Dpathfix changes the content of PATHFIX_MAKEFILEIN, whi= ch by >>>>>>> default, is Makefile.in. It won't change configure unless you set= >>>>>>> PATHFIX_MAKEFILEIN=3Dconfigure. >>>>>>> =20 >>>>>> Well, I didn't add MAKE_ARGS for fun. >>>>>> After adding USES+=3Dautoreconf, the build broke. pathfix was sti= ll in >>>>>> place. You can reproduce by adding pathfix back before "python" a= nd >>>>>> commenting out the new MAKE_ARGS line I added and check with >>>>>> "check-plist" It's easy to confirm. =20 >>>>> I never said your fix did not work or was not right, I said USES=3D= pathfix >>>>> won't touch configure. >>>>> =20 >>>> Ah, that's the issue. I misspoke. I didn't mean "configure", I mea= n >>>> the Makefile all along. So you agree in this case pathfix and >>>> autoreconf aren't compatible, right? =20 >>> Not at all, if the file patched was Makefile.in, set >>> PATHFIX_MAKEFILEIN=3DMakefile.am and it will work. =20 >> Okay, thanks, I learned something. >> I think the current approach is cleaner anyway though. > Allow me to repeat what I said barely two weeks ago: > > Can't we just use lib/pkgconfig already? Having to patch every port > to move it to libdata/pkgconfig is pointless extra work with zero benef= it. > Nobody cares that these files are in libdata. Well, we do care. hier(7) says: lib/ shared and archive ar(1)-type libraries libdata/ miscellaneous utility data files --=20 Mathieu Arnold --hauIlXNekaV9wtsKSsg0kimFbGmDixgIU-- --IL2TD9xR10U8KEkuEGRqxrPFCmbIBQaHH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJYBSCDXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85Io1gP/1TubZo5uDPptJNvbooNvThm QFVyityxvM4B+maMqdm41Tkt7BE8LKLW6cLHvVCe3ZrHe3ggxfJuzdvT3xljREfz fGTNKOmcBvN2S+cRePH41ndslfxAG2WeHheh0ewcYU5kko6eBcYKuQnlUAMXw34v fTUMT1uVRhYMxzzfdfVeR6t6TaCRduYD8K5NTJG8+QaGKpu84pgACDTfyQF1FE9N hY+eRxiQSYcbFHBz/pIU1WDOfQqXE6L4V1VsMKOe3z3oJPmjehqXRPe1xGwH2rCL bawE7WmaOEmp/xDLO9gNzS/3+eIiWFyIurHPFgo7yU0s7+n4UE1fl0XuAUgwvacD j4hAVR1Siw0HnXQZJ2tL+02ueUZp3J6EHtdCShMtm6VGH5+2K+q7eXCgBfU9e5Ce 07BaBk7PYUEcsyW68kBjvsZp9k+irYA1Ko95umVPpPB8gtnBRp6P1fetD4phhm33 rhbbV84s01bo64/zwSjDmZ+XxJtOsb+irjZbziqwGuuXj3LOQRhc9Uc4TE1Wx3iV kbFguVBXiHVHupLOZdW3Si0tV2Q2d3CTB+TTpaRQ4Lq3m9UY5+NoDC8eGrGrBhLC MxQw/G1tNNZ4BgoFDZMljCCL5NJDtMJQaa1A3p++/UNOlIsu5g1+uZ5nr/ZPSVu9 N3hyYUSL96ZWk/BnbnPm =R8rE -----END PGP SIGNATURE----- --IL2TD9xR10U8KEkuEGRqxrPFCmbIBQaHH--