From owner-p4-projects@FreeBSD.ORG Thu Jan 8 19:08:13 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 633141065670; Thu, 8 Jan 2009 19:08:13 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C8D5106566B for ; Thu, 8 Jan 2009 19:08:13 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from swip.net (mailfe08.swip.net [212.247.154.225]) by mx1.freebsd.org (Postfix) with ESMTP id 7806C8FC1A for ; Thu, 8 Jan 2009 19:08:12 +0000 (UTC) (envelope-from hselasky@freebsd.org) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=VWUNZqetDUwA:10 a=nklthdr5v5AUSfVrlghuJA==:17 a=6I5d2MoRAAAA:8 a=W44AnPxHioOjG8uGrB4A:9 a=uy7H4yfaUnKQhRuZQMgA:7 a=rGCls88uczg7S4NM4JRed8Nvr48A:4 a=SV7veod9ZcQA:10 a=LY0hPdMaydYA:10 Received: from [62.113.132.62] (account mc467741@c2i.net [62.113.132.62] verified) by mailfe08.swip.net (CommuniGate Pro SMTP 5.2.6) with ESMTPA id 1175517752; Thu, 08 Jan 2009 20:08:10 +0100 From: Hans Petter Selasky To: Remko Lodder Date: Thu, 8 Jan 2009 20:10:32 +0100 User-Agent: KMail/1.9.7 References: <200901071009.n07A9jrs056953@repoman.freebsd.org> <200901081839.27124.hselasky@freebsd.org> <61E32407-BF64-47D0-89E9-EB0B9EB22B91@elvandar.org> In-Reply-To: <61E32407-BF64-47D0-89E9-EB0B9EB22B91@elvandar.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901082010.33577.hselasky@freebsd.org> Cc: perforce@freebsd.org, "M. Warner Losh" Subject: Re: PERFORCE change 155748 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jan 2009 19:08:14 -0000 On Thursday 08 January 2009, Remko Lodder wrote: > On Jan 8, 2009, at 6:39 PM, Hans Petter Selasky wrote: > > On Thursday 08 January 2009, M. Warner Losh wrote: > >> In message: <200901071009.n07A9jrs056953@repoman.freebsd.org> > >> > >> Hans Petter Selasky writes: > >> : http://perforce.freebsd.org/chv.cgi?CH=155748 > >> : > >> : Change 155748 by hselasky@hselasky_laptop001 on 2009/01/07 10:09:35 > >> : > >> : > >> : Umass module quirk from Alexander Best > >> : to support Meizu Electronics MiniPlayer. > >> : > >> : Affected files ... > >> : > >> : .. //depot/projects/usb/src/sys/dev/usb/usbdevs#35 edit > >> : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21 > >> > >> edit > >> > >> : .. //depot/projects/usb/src/sys/dev/usb2/include/ > >> > >> usb2_devtable.h#21 edit > >> > >> : .. //depot/projects/usb/src/sys/dev/usb2/storage/umass2.c#20 edit > >> : > >> : ==== //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21 > >> : (text+ko) ==== ==== > >> : //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#21 > >> : (text+ko) ==== > >> > >> Why are these generated files committed to the tree? We did a lot of > >> work to make usbdevs generated files not need to be committed to the > >> tree and this breaks that... > >> > >> Warner > > > > Because they are not automatically generated any more. > > > > --HPS > > Hmm, I liked the idea of only needing to do something marginally to > add something. If files are no longer generated automatically and I > need to do more, I'll look for other low hanging fruit. > > In short: can you restore automatic regenerating behaviour? Hi Remko, Everything is possible. How would you explain the benefit of the +19Mbyte of data resulting from this autogeneration when building the modules ? 126035 Jan 7 11:12 usb2_devid.h 197224 Jan 7 11:12 usb2_devtable.h 197+126 ans = 323 ans * 60 ans = 19380 --HPS