From owner-svn-ports-all@FreeBSD.ORG Sat Jun 14 18:03:21 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CD4A0B25; Sat, 14 Jun 2014 18:03:21 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A37D422E0; Sat, 14 Jun 2014 18:03:21 +0000 (UTC) Received: from [192.168.0.21] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 4C318435C7; Sat, 14 Jun 2014 13:03:02 -0500 (CDT) Message-ID: <539C8E46.1010803@marino.st> Date: Sat, 14 Jun 2014 20:02:46 +0200 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Steve Wills , marino@freebsd.org Subject: Re: svn commit: r357767 - head/net/cyphesis References: <201406141111.s5EBBCgV016094@svn.freebsd.org> <539C8682.3030603@marino.st> <20140614175243.GD67971@mouf.net> In-Reply-To: <20140614175243.GD67971@mouf.net> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Oliver Lehmann , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jun 2014 18:03:21 -0000 On 6/14/2014 19:52, Steve Wills wrote: > On Sat, Jun 14, 2014 at 07:29:38PM +0200, John Marino wrote: >> On 6/14/2014 13:11, Oliver Lehmann wrote: >>> Author: oliver >>> Date: Sat Jun 14 11:11:11 2014 >>> New Revision: 357767 >>> URL: http://svnweb.freebsd.org/changeset/ports/357767 >>> QAT: https://qat.redports.org/buildarchive/r357767/ >>> >>> Log: >>> mark as BROKEN (Does not compile with clang) >>> >> >> >> But FreeBSD 8 and 9 are still supported, and it builds on those: >> http://portsmon.freebsd.org/portoverview.py?category=net&portname=cyphesis >> >> So marking this unconditionally broken breaks it on those platforms, and >> DragonFly too. >> >> It seems to me the action to take is: >> 1) fix it so builds regardless of compiler >> 2) nothing. (F8, F9, + DF is better than broken everywhere. > > Wouldn't the right thing be to mark it broken on FreeBSD 8 and 9 only, via > conditionals? No. If you were going to test for anything, you'd test for clang, not the platform. Secondly, what's the benefit of marking it broken? For people that try to build it via source? To save the builder the effort of trying? I don't think there's much benefit and in this case, there's a distinct downside. John